Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
WebRTC Code Reviews
Help
|
Chromium Project
|
Sign in
(19)
Issues
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
1124006
: NOT FOR SUBMISSION: To support external decoder.
Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by
dwkang1
Modified:
4 years, 9 months ago
Reviewers:
Base URL:
https://chromium.googlesource.com/external/libjingle.git@master
Visibility:
Public.
More Reviews
Description
NOT FOR SUBMISSION: To support external decoder. TODO: need to get decoder factory rather than decoder instance.
Patch Set 1
#
Patch Set 2 :
#
Patch Set 3 : introducing decoder factory.
#
Patch Set 4 : adding a missing file.
#
Patch Set 5 : introducing factory.
#
Created:
7 years, 10 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+146 lines, -27 lines
)
Patch
M
talk/app/webrtc/peerconnection_unittest.cc
View
1
2
3
4
1 chunk
+1 line, -1 line
0 comments
Download
M
talk/app/webrtc/peerconnectionfactory.h
View
1
2
3
4
2 chunks
+5 lines, -1 line
0 comments
Download
M
talk/app/webrtc/peerconnectionfactory.cc
View
1
2
3
4
4 chunks
+10 lines, -5 lines
0 comments
Download
M
talk/app/webrtc/peerconnectionfactory_unittest.cc
View
1
2
3
4
1 chunk
+1 line, -0 lines
0 comments
Download
M
talk/app/webrtc/peerconnectioninterface.h
View
1
2
2 chunks
+7 lines, -3 lines
0 comments
Download
M
talk/app/webrtc/peerconnectioninterface_unittest.cc
View
1
2
3
4
1 chunk
+1 line, -1 line
0 comments
Download
A +
talk/app/webrtc/videodecoderfactory.h
View
1
2
3
4
1 chunk
+19 lines, -10 lines
0 comments
Download
M
talk/media/webrtc/webrtcmediaengine.h
View
1
2
2 chunks
+4 lines, -1 line
0 comments
Download
M
talk/media/webrtc/webrtcvideoengine.h
View
1
2
7 chunks
+11 lines, -0 lines
0 comments
Download
M
talk/media/webrtc/webrtcvideoengine.cc
View
1
2
3
4
8 chunks
+78 lines, -2 lines
0 comments
Download
M
talk/media/webrtc/webrtcvie.h
View
1
2
3
4
5 chunks
+9 lines, -3 lines
0 comments
Download
Trybot results:
More>>>
<<<Less
Sign in
to try more bots
Issue 1124006: NOT FOR SUBMISSION: To support external decoder.
Created 7 years, 11 months ago by dwkang1
Modified 4 years, 9 months ago
Reviewers:
Base URL: https://chromium.googlesource.com/external/libjingle.git@master
Comments: 0
Recent Issues
|
This issue
This is Rietveld
245c2c2-tainted