Issue 29349004: Stop compiling libjingle in WebRTC standalone. This means webrtc/libjingle, not the talk/ director…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29349004: Stop compiling libjingle in WebRTC standalone. This means webrtc/libjingle, not the talk/ director…

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 4 months ago by pthatcher

Modified:
4 years, 6 months ago

Reviewers:
pbos, juberti_webrtc, yarycintoracampos1993

CC:
webrtc-reviews_webrtc.org, tterriberry, qiang.lu, Niklas, yujie.mao, ajm

Base URL:
https://webrtc.googlecode.com/svn/trunk

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Stop compiling libjingle in WebRTC standalone. This means webrtc/libjingle, not the talk/ directory, which is no longer part of libjingle.

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -13 lines)			Patch
M	talk/libjingle.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	talk/libjingle_tests.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webrtc/build/merge_libs.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	webrtc/webrtc.gyp	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	webrtc/webrtc_tests.gypi	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Trybot results: Sign in to try more bots

Project "webrtc" does not have a commit queue.

Messages

Total messages: 8 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pthatcher

We have to keep the files there until ChromeSync and Chromoting stop compiling them, but ...

6 years, 4 months ago (2014-12-29 19:35:25 UTC) #2

pbos

I don't think we should remove these unittests before they are gone from Chrome, or ...

6 years, 4 months ago (2015-01-02 09:34:44 UTC) #3

pthatcher

4 years, 6 months ago (2016-10-27 16:37:24 UTC) #8

On 2016/10/23 10:15:58, yarycintoracampos1993 wrote:

lgtm


I'm not worried about rolls to Chromium for two reasons:

1.  These files never change.
2.  We don't need to roll these files any more.  In fact, we could delete them
from our repository as long as we don't roll the deletes into Chromium (as long
as the files stay there in Chromium).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages