Adding setting screen to AppRTCDemo.

Adding setting screen to AppRTCDemo.

- Move server URL from connection screen
to the setting screen.
- Add setting for local video resolution.
- Auto save last entered room number.
- Use full screen mode in video renderer and fix
texture offsets recalculation when rendering type is
dynamically changed.

BUG=3935, 3953
R=kjellander@webrtc.org, pbos@webrtc.org, pthatcher@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=7534

[AlexGl, 2014-10-23 00:43:02]

PTAL

[pbos, 2014-10-23 15:40:19]

Stopped checking half-way, running out of time (heading out soon).

I don't think you want a settings screen for most of these (maybe only for
URL?), but rather that it remembered your last settings and filled those in when
you start the app.

Maybe a "reset settings" button in a settings menu (etc.) in the connect
activity is enough so that you can get https://appspot.<...> back easily?

WDYT?

https://review.webrtc.org/30769004/diff/20001/talk/examples/android/res/xml/p...
File talk/examples/android/res/xml/preferences.xml (right):

https://review.webrtc.org/30769004/diff/20001/talk/examples/android/res/xml/p...
talk/examples/android/res/xml/preferences.xml:6:
android:summary="@string/pref_loopback_summ"
s/summ/summary

https://review.webrtc.org/30769004/diff/20001/talk/examples/android/src/org/a...
File talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java (right):

https://review.webrtc.org/30769004/diff/20001/talk/examples/android/src/org/a...
talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java:71:
keypref_url  = getString(R.string.pref_url_key);
remove double-space

https://review.webrtc.org/30769004/diff/20001/talk/examples/android/src/org/a...
talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java:72:
keypref_room  = getString(R.string.pref_room_key);
remove double-space

https://review.webrtc.org/30769004/diff/20001/talk/examples/android/src/org/a...
talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java:105: boolean
loopback = sharedPref.getBoolean(keypref_loopback, false);
Are you sure loopback should go under preferences? I'd like this to be visible
so you know what's selected? Checkbox sounded good, though I haven't seen it.

https://review.webrtc.org/30769004/diff/20001/talk/examples/android/src/org/a...
File talk/examples/android/src/org/appspot/apprtc/SettingsActivity.java (right):

https://review.webrtc.org/30769004/diff/20001/talk/examples/android/src/org/a...
talk/examples/android/src/org/appspot/apprtc/SettingsActivity.java:44:
keypref_url  = getString(R.string.pref_url_key);
remove double-space

https://review.webrtc.org/30769004/diff/20001/talk/libjingle_examples.gyp
File talk/libjingle_examples.gyp (right):

https://review.webrtc.org/30769004/diff/20001/talk/libjingle_examples.gyp#new...
talk/libjingle_examples.gyp:344:
'examples/android/src/org/appspot/apprtc//SettingsActivity.java',
Remove double-slash.

https://review.webrtc.org/30769004/diff/20001/talk/libjingle_examples.gyp#new...
talk/libjingle_examples.gyp:345:
'examples/android/src/org/appspot/apprtc//SettingsFragment.java',
Remove double-slash.

[AlexGl, 2014-10-23 20:36:09]

PTAL

https://review.webrtc.org/30769004/diff/20001/talk/examples/android/res/xml/p...
File talk/examples/android/res/xml/preferences.xml (right):

https://review.webrtc.org/30769004/diff/20001/talk/examples/android/res/xml/p...
talk/examples/android/res/xml/preferences.xml:6:
android:summary="@string/pref_loopback_summ"
On 2014/10/23 15:40:19, pbos wrote:
> s/summ/summary

Done.

https://review.webrtc.org/30769004/diff/20001/talk/examples/android/src/org/a...
File talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java (right):

https://review.webrtc.org/30769004/diff/20001/talk/examples/android/src/org/a...
talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java:71:
keypref_url  = getString(R.string.pref_url_key);
On 2014/10/23 15:40:19, pbos wrote:
> remove double-space

Done.

https://review.webrtc.org/30769004/diff/20001/talk/examples/android/src/org/a...
talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java:72:
keypref_room  = getString(R.string.pref_room_key);
On 2014/10/23 15:40:19, pbos wrote:
> remove double-space

Done.

https://review.webrtc.org/30769004/diff/20001/talk/examples/android/src/org/a...
talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java:105: boolean
loopback = sharedPref.getBoolean(keypref_loopback, false);
On 2014/10/23 15:40:19, pbos wrote:
> Are you sure loopback should go under preferences? I'd like this to be visible
> so you know what's selected? Checkbox sounded good, though I haven't seen it.

Done - moved back to connection activity.

https://review.webrtc.org/30769004/diff/20001/talk/examples/android/src/org/a...
File talk/examples/android/src/org/appspot/apprtc/SettingsActivity.java (right):

https://review.webrtc.org/30769004/diff/20001/talk/examples/android/src/org/a...
talk/examples/android/src/org/appspot/apprtc/SettingsActivity.java:44:
keypref_url  = getString(R.string.pref_url_key);
On 2014/10/23 15:40:19, pbos wrote:
> remove double-space

Done.

https://review.webrtc.org/30769004/diff/20001/talk/libjingle_examples.gyp
File talk/libjingle_examples.gyp (right):

https://review.webrtc.org/30769004/diff/20001/talk/libjingle_examples.gyp#new...
talk/libjingle_examples.gyp:344:
'examples/android/src/org/appspot/apprtc//SettingsActivity.java',
On 2014/10/23 15:40:19, pbos wrote:
> Remove double-slash.

Done.

https://review.webrtc.org/30769004/diff/20001/talk/libjingle_examples.gyp#new...
talk/libjingle_examples.gyp:344:
'examples/android/src/org/appspot/apprtc//SettingsActivity.java',
On 2014/10/23 15:40:19, pbos wrote:
> Remove double-slash.

Done.

https://review.webrtc.org/30769004/diff/20001/talk/libjingle_examples.gyp#new...
talk/libjingle_examples.gyp:345:
'examples/android/src/org/appspot/apprtc//SettingsFragment.java',
On 2014/10/23 15:40:19, pbos wrote:
> Remove double-slash.

Done.

[AlexGl, 2014-10-23 21:06:27]

On 2014/10/23 15:40:19, pbos wrote:
> Stopped checking half-way, running out of time (heading out soon).
> 
> I don't think you want a settings screen for most of these (maybe only for
> URL?), but rather that it remembered your last settings and filled those in
when
> you start the app.
> 
> Maybe a "reset settings" button in a settings menu (etc.) in the connect
> activity is enough so that you can get https://appspot.%3C...%3E back easily?
> 
> WDYT?

I agree with loopback checkbox - it's more convenient to have it in conenct
activity. For the rest I am trying to follow UI sketch at issue 3939 and based
on my quick sync up with Justin - connect activity with room list and buttons to
edit the list and do the call and rest should go to settings. In the near future
settings screen will probably contain controls for fps, codecs and video scaling
type.
Reset button makes sense as well, but probably can be done in separate CL.

[pbos, 2014-10-24 09:12:17]

lgtm w/ one question:

Isn't there some theme-based settings icon (Android builtin) that you can use
instead of adding one?

[kjellander, 2014-10-24 12:22:45]

lgtm but I'd like that empty catch clause to be fixed.

https://webrtc-codereview.appspot.com/30769004/diff/40001/talk/app/webrtc/jav...
File talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java (right):

https://webrtc-codereview.appspot.com/30769004/diff/40001/talk/app/webrtc/jav...
talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java:693:
GLES20.glClearColor(0.15f, 0.15f, 0.15f, 1.0f);
Things like these values should probably go into a res/values/dimens.xml file,
but that can be done in a future CL.

https://webrtc-codereview.appspot.com/30769004/diff/40001/talk/examples/andro...
File talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java (right):

https://webrtc-codereview.appspot.com/30769004/diff/40001/talk/examples/andro...
talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java:127: }
Empty catch clauses are dangerous. If this is expected an error dialog should be
displayed or at least an error log should be written.

https://webrtc-codereview.appspot.com/30769004/diff/40001/talk/examples/andro...
talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java:143: // Handle
presses on the action bar items
über-nit: end comments with punctuation.

[AlexGl, 2014-10-24 17:58:14]

On 2014/10/24 09:12:17, pbos wrote:
> lgtm w/ one question:
> 
> Isn't there some theme-based settings icon (Android builtin) that you can use
> instead of adding one?

Done

[AlexGl, 2014-10-24 17:59:04]

https://webrtc-codereview.appspot.com/30769004/diff/40001/talk/examples/andro...
File talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java (right):

https://webrtc-codereview.appspot.com/30769004/diff/40001/talk/examples/andro...
talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java:127: }
On 2014/10/24 12:22:45, kjellander wrote:
> Empty catch clauses are dangerous. If this is expected an error dialog should
be
> displayed or at least an error log should be written.

Done.

https://webrtc-codereview.appspot.com/30769004/diff/40001/talk/examples/andro...
talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java:143: // Handle
presses on the action bar items
On 2014/10/24 12:22:45, kjellander wrote:
> über-nit: end comments with punctuation.

Done.

[AlexGl, 2014-10-24 18:00:17]

+ Peter for libjingle_examples.gyp owner approval

[pthatcher, 2014-10-27 17:20:16]

lgtm

[AlexGl, 2014-10-27 17:22:26]

Committed patchset #4 (id:60001) manually as 7534 (presubmit successful).

[addyjulie622, 2018-09-30 17:03:31]

addyjulie622@gmail.com changed reviewers:
+ addyjulie622@gmail.com