On 2014/10/23 15:40:19, pbos wrote: > Stopped checking half-way, running out of time (heading out ...
6 years, 3 months ago
(2014-10-23 21:06:27 UTC)
#4
On 2014/10/23 15:40:19, pbos wrote:
> Stopped checking half-way, running out of time (heading out soon).
>
> I don't think you want a settings screen for most of these (maybe only for
> URL?), but rather that it remembered your last settings and filled those in
when
> you start the app.
>
> Maybe a "reset settings" button in a settings menu (etc.) in the connect
> activity is enough so that you can get https://appspot.%3C...%3E back easily?
>
> WDYT?
I agree with loopback checkbox - it's more convenient to have it in conenct
activity. For the rest I am trying to follow UI sketch at issue 3939 and based
on my quick sync up with Justin - connect activity with room list and buttons to
edit the list and do the call and rest should go to settings. In the near future
settings screen will probably contain controls for fps, codecs and video scaling
type.
Reset button makes sense as well, but probably can be done in separate CL.
lgtm but I'd like that empty catch clause to be fixed. https://webrtc-codereview.appspot.com/30769004/diff/40001/talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java File talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java (right): ...
6 years, 3 months ago
(2014-10-24 12:22:45 UTC)
#6
On 2014/10/24 09:12:17, pbos wrote: > lgtm w/ one question: > > Isn't there some ...
6 years, 3 months ago
(2014-10-24 17:58:14 UTC)
#7
On 2014/10/24 09:12:17, pbos wrote:
> lgtm w/ one question:
>
> Isn't there some theme-based settings icon (Android builtin) that you can use
> instead of adding one?
Done
Issue 30769004: Adding setting screen to AppRTCDemo.
(Closed)
Created 6 years, 3 months ago by AlexGl
Modified 2 years, 3 months ago
Reviewers: kjellander, pbos, braveyao1, pthatcher, addyjulie622
Base URL: http://webrtc.googlecode.com/svn/trunk
Comments: 20