WebRTC Code Reviews
Help | Chromium Project | Sign in
(10893)

Issue 30769004: Adding setting screen to AppRTCDemo. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by AlexGl
Modified:
1 year, 1 month ago
CC:
webrtc-reviews_webrtc.org, rillian-moz, yujie.mao, ajm, tterriberry, qiang.lu, Niklas
Base URL:
http://webrtc.googlecode.com/svn/trunk
Visibility:
Public.

Description

Adding setting screen to AppRTCDemo. - Move server URL from connection screen to the setting screen. - Add setting for local video resolution. - Auto save last entered room number. - Use full screen mode in video renderer and fix texture offsets recalculation when rendering type is dynamically changed. BUG=3935, 3953 R=kjellander@webrtc.org, pbos@webrtc.org, pthatcher@webrtc.org Committed: https://code.google.com/p/webrtc/source/detail?r=7534

Patch Set 1 #

Patch Set 2 : Remove extra logging. #

Total comments: 15

Patch Set 3 : Addressing the comments and adding video resolution settings. #

Total comments: 5

Patch Set 4 : Rebase + addressing the comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -57 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java View 4 chunks +22 lines, -22 lines 0 comments Download
M talk/examples/android/AndroidManifest.xml View 3 chunks +7 lines, -1 line 0 comments Download
M talk/examples/android/res/layout/activity_connect.xml View 1 2 2 chunks +2 lines, -14 lines 0 comments Download
A talk/examples/android/res/menu/connect_menu.xml View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
A talk/examples/android/res/values/arrays.xml View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M talk/examples/android/res/values/strings.xml View 1 2 2 chunks +17 lines, -1 line 0 comments Download
A talk/examples/android/res/xml/preferences.xml View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M talk/examples/android/src/org/appspot/apprtc/AppRTCDemoActivity.java View 1 chunk +2 lines, -2 lines 0 comments Download
M talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java View 1 2 3 5 chunks +72 lines, -7 lines 0 comments Download
A talk/examples/android/src/org/appspot/apprtc/SettingsActivity.java View 1 2 1 chunk +88 lines, -0 lines 0 comments Download
A + talk/examples/android/src/org/appspot/apprtc/SettingsFragment.java View 2 chunks +12 lines, -10 lines 0 comments Download
M talk/libjingle_examples.gyp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (1 generated)
AlexGl
PTAL
5 years ago (2014-10-23 00:43:02 UTC) #1
pbos
Stopped checking half-way, running out of time (heading out soon). I don't think you want ...
5 years ago (2014-10-23 15:40:19 UTC) #2
AlexGl
PTAL https://review.webrtc.org/30769004/diff/20001/talk/examples/android/res/xml/preferences.xml File talk/examples/android/res/xml/preferences.xml (right): https://review.webrtc.org/30769004/diff/20001/talk/examples/android/res/xml/preferences.xml#newcode6 talk/examples/android/res/xml/preferences.xml:6: android:summary="@string/pref_loopback_summ" On 2014/10/23 15:40:19, pbos wrote: > s/summ/summary ...
5 years ago (2014-10-23 20:36:09 UTC) #3
AlexGl
On 2014/10/23 15:40:19, pbos wrote: > Stopped checking half-way, running out of time (heading out ...
5 years ago (2014-10-23 21:06:27 UTC) #4
pbos
lgtm w/ one question: Isn't there some theme-based settings icon (Android builtin) that you can ...
5 years ago (2014-10-24 09:12:17 UTC) #5
kjellander
lgtm but I'd like that empty catch clause to be fixed. https://webrtc-codereview.appspot.com/30769004/diff/40001/talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java File talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java (right): ...
5 years ago (2014-10-24 12:22:45 UTC) #6
AlexGl
On 2014/10/24 09:12:17, pbos wrote: > lgtm w/ one question: > > Isn't there some ...
5 years ago (2014-10-24 17:58:14 UTC) #7
AlexGl
https://webrtc-codereview.appspot.com/30769004/diff/40001/talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java File talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java (right): https://webrtc-codereview.appspot.com/30769004/diff/40001/talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java#newcode127 talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java:127: } On 2014/10/24 12:22:45, kjellander wrote: > Empty catch ...
5 years ago (2014-10-24 17:59:04 UTC) #8
AlexGl
+ Peter for libjingle_examples.gyp owner approval
5 years ago (2014-10-24 18:00:17 UTC) #9
pthatcher
lgtm
5 years ago (2014-10-27 17:20:16 UTC) #10
AlexGl
Committed patchset #4 (id:60001) manually as 7534 (presubmit successful).
5 years ago (2014-10-27 17:22:26 UTC) #11
addyjulie622
1 year, 1 month ago (2018-09-30 17:03:32 UTC) #13
Message was sent while issue was closed.

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted