WebRTC Code Reviews
Help | Chromium Project | Sign in
(10878)

Issue 35569004: Delete webrtc/libjingle, except for xmpp/ and xmllite/, which must stay around until all the parts … (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by pthatcher
Modified:
3 years, 11 months ago
Reviewers:
juberti_webrtc, pbos
CC:
webrtc-reviews_webrtc.org, rillian-moz, tterriberry
Base URL:
https://webrtc.googlecode.com/svn/trunk
Project:
webrtc
Visibility:
Public.

Description

Delete webrtc/libjingle, except for xmpp/ and xmllite/, which must stay around until all the parts of Chromium stop using them. Note that we can't submit this until we submit https://webrtc-codereview.appspot.com/29319004 and https://codereview.chromium.org/811673002/

Patch Set 1 #

Patch Set 2 : delete-libjingle-session2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20054 lines) Patch
D webrtc/libjingle/examples/call/Info.plist View 1 chunk +0 lines, -11 lines 0 comments Download
D webrtc/libjingle/examples/call/call_main.cc View 1 chunk +0 lines, -497 lines 0 comments Download
D webrtc/libjingle/examples/call/call_unittest.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D webrtc/libjingle/examples/call/callclient.h View 1 chunk +0 lines, -352 lines 0 comments Download
D webrtc/libjingle/examples/call/callclient.cc View 1 chunk +0 lines, -1616 lines 0 comments Download
D webrtc/libjingle/examples/call/callclient_unittest.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D webrtc/libjingle/examples/call/console.h View 1 chunk +0 lines, -70 lines 0 comments Download
D webrtc/libjingle/examples/call/console.cc View 1 chunk +0 lines, -169 lines 0 comments Download
D webrtc/libjingle/examples/call/friendinvitesendtask.h View 1 chunk +0 lines, -49 lines 0 comments Download
D webrtc/libjingle/examples/call/friendinvitesendtask.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D webrtc/libjingle/examples/call/mediaenginefactory.h View 1 chunk +0 lines, -40 lines 0 comments Download
D webrtc/libjingle/examples/call/mediaenginefactory.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D webrtc/libjingle/examples/call/muc.h View 1 chunk +0 lines, -66 lines 0 comments Download
D webrtc/libjingle/examples/call/mucinviterecvtask.h View 1 chunk +0 lines, -82 lines 0 comments Download
D webrtc/libjingle/examples/call/mucinviterecvtask.cc View 1 chunk +0 lines, -124 lines 0 comments Download
D webrtc/libjingle/examples/call/mucinvitesendtask.h View 1 chunk +0 lines, -50 lines 0 comments Download
D webrtc/libjingle/examples/call/mucinvitesendtask.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D webrtc/libjingle/examples/call/presencepushtask.h View 1 chunk +0 lines, -70 lines 0 comments Download
D webrtc/libjingle/examples/call/presencepushtask.cc View 1 chunk +0 lines, -222 lines 0 comments Download
D webrtc/libjingle/examples/login/login_main.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D webrtc/libjingle/libjingle.gyp View 1 1 chunk +0 lines, -183 lines 0 comments Download
D webrtc/libjingle/session/constants.h View 1 1 chunk +0 lines, -219 lines 0 comments Download
D webrtc/libjingle/session/constants.cc View 1 1 chunk +0 lines, -217 lines 0 comments Download
D webrtc/libjingle/session/media/call.h View 1 chunk +0 lines, -308 lines 0 comments Download
D webrtc/libjingle/session/media/call.cc View 1 1 chunk +0 lines, -1134 lines 0 comments Download
D webrtc/libjingle/session/media/mediamessages.h View 1 1 chunk +0 lines, -98 lines 0 comments Download
D webrtc/libjingle/session/media/mediamessages.cc View 1 chunk +0 lines, -332 lines 0 comments Download
D webrtc/libjingle/session/media/mediamessages_unittest.cc View 1 chunk +0 lines, -363 lines 0 comments Download
D webrtc/libjingle/session/media/mediasessionclient.h View 1 1 chunk +0 lines, -175 lines 0 comments Download
D webrtc/libjingle/session/media/mediasessionclient.cc View 1 1 chunk +0 lines, -1160 lines 0 comments Download
D webrtc/libjingle/session/media/mediasessionclient_unittest.cc View 1 chunk +0 lines, -3324 lines 0 comments Download
D webrtc/libjingle/session/p2ptransportparser.h View 1 1 chunk +0 lines, -67 lines 0 comments Download
D webrtc/libjingle/session/p2ptransportparser.cc View 1 1 chunk +0 lines, -216 lines 0 comments Download
D webrtc/libjingle/session/parsing.h View 1 1 chunk +0 lines, -140 lines 0 comments Download
D webrtc/libjingle/session/parsing.cc View 1 1 chunk +0 lines, -141 lines 0 comments Download
D webrtc/libjingle/session/rawtransportparser.h View 1 1 chunk +0 lines, -49 lines 0 comments Download
D webrtc/libjingle/session/rawtransportparser.cc View 1 1 chunk +0 lines, -92 lines 0 comments Download
D webrtc/libjingle/session/session_unittest.cc View 1 1 chunk +0 lines, -2429 lines 0 comments Download
D webrtc/libjingle/session/sessionclient.h View 1 1 chunk +0 lines, -80 lines 0 comments Download
D webrtc/libjingle/session/sessionmanager.h View 1 1 chunk +0 lines, -436 lines 0 comments Download
D webrtc/libjingle/session/sessionmanager.cc View 1 1 chunk +0 lines, -1150 lines 0 comments Download
D webrtc/libjingle/session/sessionmanagertask.h View 1 1 chunk +0 lines, -76 lines 0 comments Download
D webrtc/libjingle/session/sessionmessages.h View 1 1 chunk +0 lines, -219 lines 0 comments Download
D webrtc/libjingle/session/sessionmessages.cc View 1 1 chunk +0 lines, -1132 lines 0 comments Download
D webrtc/libjingle/session/sessionsendtask.h View 1 1 chunk +0 lines, -128 lines 0 comments Download
D webrtc/libjingle/session/transportparser.h View 1 1 chunk +0 lines, -78 lines 0 comments Download
D webrtc/libjingle/session/transportparser.cc View 1 1 chunk +0 lines, -38 lines 0 comments Download
D webrtc/libjingle/session/transportparser_unittest.cc View 1 1 chunk +0 lines, -136 lines 0 comments Download
D webrtc/libjingle/session/tunnel/pseudotcpchannel.h View 1 chunk +0 lines, -140 lines 0 comments Download
D webrtc/libjingle/session/tunnel/pseudotcpchannel.cc View 1 chunk +0 lines, -603 lines 0 comments Download
D webrtc/libjingle/session/tunnel/securetunnelsessionclient.h View 1 chunk +0 lines, -165 lines 0 comments Download
D webrtc/libjingle/session/tunnel/securetunnelsessionclient.cc View 1 chunk +0 lines, -397 lines 0 comments Download
D webrtc/libjingle/session/tunnel/tunnelsessionclient.h View 1 1 chunk +0 lines, -182 lines 0 comments Download
D webrtc/libjingle/session/tunnel/tunnelsessionclient.cc View 1 chunk +0 lines, -432 lines 0 comments Download
D webrtc/libjingle/session/tunnel/tunnelsessionclient_unittest.cc View 1 chunk +0 lines, -226 lines 0 comments Download
Trybot results:
Project "webrtc" does not have a commit queue.

Messages

Total messages: 3 (0 generated)
pthatcher
This is the end goal, but we need to submit 2 CLs before it. Soooooo ...
4 years, 11 months ago (2014-12-20 01:34:51 UTC) #1
alex gouaillard
On 2014/12/20 01:34:51, pthatcher wrote: > This is the end goal, but we need to ...
3 years, 11 months ago (2015-12-19 08:10:44 UTC) #2
pbos
3 years, 11 months ago (2015-12-19 10:58:57 UTC) #3
On 2015/12/19 08:10:44, alex gouaillard wrote:
> On 2014/12/20 01:34:51, pthatcher wrote:
> > This is the end goal, but we need to submit 2 CLs before it.  Soooooo close.
> 
> looking at the code in the 47 branch, this seems to have happened already.
Shall
> we close this CL?

Gone in master too, closing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted