WebRTC Code Reviews
Help | Chromium Project | Sign in
(11967)

Issue 36439004: Revert r7886:7887. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by pbos
Modified:
3 years, 9 months ago
Reviewers:
tommi, kjellander, pthatcher
CC:
webrtc-reviews_webrtc.org, rillian-moz, yujie.mao, ajm, tterriberry, qiang.lu, Niklas
Base URL:
http://webrtc.googlecode.com/svn/trunk
Project:
webrtc
Visibility:
Public.

Description

Revert r7886:7887. Broke build steps in other code that uses securetunnelsessionclient.cc and others. TBR=tommi@webrtc.org,pthatcher@webrtc.org BUG= Committed: https://code.google.com/p/webrtc/source/detail?r=7890

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -15626 lines) Patch
M all.gyp View 1 chunk +0 lines, -1 line 1 comment Download
M talk/app/webrtc/webrtcsdp.cc View 1 chunk +1 line, -1 line 0 comments Download
A + talk/examples/call/Info.plist View 0 chunks +-1 lines, --1 lines 0 comments Download
A + talk/examples/call/call_main.cc View 1 chunk +1 line, -1 line 0 comments Download
A + talk/examples/call/call_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + talk/examples/call/callclient.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + talk/examples/call/callclient.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + talk/examples/call/callclient_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + talk/examples/call/console.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + talk/examples/call/console.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + talk/examples/call/friendinvitesendtask.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + talk/examples/call/friendinvitesendtask.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + talk/examples/call/mediaenginefactory.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + talk/examples/call/mediaenginefactory.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + talk/examples/call/muc.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + talk/examples/call/mucinviterecvtask.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + talk/examples/call/mucinviterecvtask.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + talk/examples/call/mucinvitesendtask.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + talk/examples/call/mucinvitesendtask.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + talk/examples/call/presencepushtask.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + talk/examples/call/presencepushtask.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + talk/examples/login/login_main.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M talk/libjingle.gyp View 1 chunk +12 lines, -0 lines 0 comments Download
M talk/libjingle_examples.gyp View 3 chunks +73 lines, -0 lines 0 comments Download
M talk/libjingle_tests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + talk/session/media/call.h View 1 chunk +1 line, -1 line 0 comments Download
A + talk/session/media/call.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M talk/session/media/channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M talk/session/media/channel_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M talk/session/media/currentspeakermonitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M talk/session/media/currentspeakermonitor_unittest.cc View 13 chunks +29 lines, -22 lines 0 comments Download
A + talk/session/media/mediamessages.h View 1 chunk +1 line, -1 line 0 comments Download
A + talk/session/media/mediamessages.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + talk/session/media/mediamessages_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + talk/session/media/mediasessionclient.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + talk/session/media/mediasessionclient.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + talk/session/media/mediasessionclient_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + talk/session/tunnel/pseudotcpchannel.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + talk/session/tunnel/pseudotcpchannel.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + talk/session/tunnel/securetunnelsessionclient.h View 1 chunk +1 line, -1 line 0 comments Download
A + talk/session/tunnel/securetunnelsessionclient.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + talk/session/tunnel/tunnelsessionclient.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + talk/session/tunnel/tunnelsessionclient.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + talk/session/tunnel/tunnelsessionclient_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D webrtc/libjingle/OWNERS View 1 chunk +0 lines, -13 lines 0 comments Download
D webrtc/libjingle/examples/call/Info.plist View 1 chunk +0 lines, -11 lines 0 comments Download
D webrtc/libjingle/examples/call/call_main.cc View 1 chunk +0 lines, -497 lines 0 comments Download
D webrtc/libjingle/examples/call/call_unittest.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D webrtc/libjingle/examples/call/callclient.h View 1 chunk +0 lines, -352 lines 0 comments Download
D webrtc/libjingle/examples/call/callclient.cc View 1 chunk +0 lines, -1616 lines 0 comments Download
D webrtc/libjingle/examples/call/callclient_unittest.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D webrtc/libjingle/examples/call/console.h View 1 chunk +0 lines, -70 lines 0 comments Download
D webrtc/libjingle/examples/call/console.cc View 1 chunk +0 lines, -169 lines 0 comments Download
D webrtc/libjingle/examples/call/friendinvitesendtask.h View 1 chunk +0 lines, -49 lines 0 comments Download
D webrtc/libjingle/examples/call/friendinvitesendtask.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D webrtc/libjingle/examples/call/mediaenginefactory.h View 1 chunk +0 lines, -40 lines 0 comments Download
D webrtc/libjingle/examples/call/mediaenginefactory.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D webrtc/libjingle/examples/call/muc.h View 1 chunk +0 lines, -66 lines 0 comments Download
D webrtc/libjingle/examples/call/mucinviterecvtask.h View 1 chunk +0 lines, -82 lines 0 comments Download
D webrtc/libjingle/examples/call/mucinviterecvtask.cc View 1 chunk +0 lines, -124 lines 0 comments Download
D webrtc/libjingle/examples/call/mucinvitesendtask.h View 1 chunk +0 lines, -50 lines 0 comments Download
D webrtc/libjingle/examples/call/mucinvitesendtask.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D webrtc/libjingle/examples/call/presencepushtask.h View 1 chunk +0 lines, -70 lines 0 comments Download
D webrtc/libjingle/examples/call/presencepushtask.cc View 1 chunk +0 lines, -222 lines 0 comments Download
D webrtc/libjingle/examples/login/login_main.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D webrtc/libjingle/libjingle.gyp View 1 chunk +0 lines, -171 lines 0 comments Download
D webrtc/libjingle/media/call.h View 1 chunk +0 lines, -307 lines 0 comments Download
D webrtc/libjingle/media/call.cc View 1 chunk +0 lines, -1132 lines 0 comments Download
D webrtc/libjingle/media/mediamessages.h View 1 chunk +0 lines, -169 lines 0 comments Download
D webrtc/libjingle/media/mediamessages.cc View 1 chunk +0 lines, -387 lines 0 comments Download
D webrtc/libjingle/media/mediamessages_unittest.cc View 1 chunk +0 lines, -363 lines 0 comments Download
D webrtc/libjingle/media/mediasessionclient.h View 1 chunk +0 lines, -175 lines 0 comments Download
D webrtc/libjingle/media/mediasessionclient.cc View 1 chunk +0 lines, -1161 lines 0 comments Download
D webrtc/libjingle/media/mediasessionclient_unittest.cc View 1 chunk +0 lines, -3324 lines 0 comments Download
D webrtc/libjingle/session/parsing.h View 1 chunk +0 lines, -140 lines 0 comments Download
D webrtc/libjingle/session/parsing.cc View 1 chunk +0 lines, -141 lines 0 comments Download
D webrtc/libjingle/session/sessionclient.h View 1 chunk +0 lines, -78 lines 0 comments Download
D webrtc/libjingle/session/sessionmanager.h View 1 chunk +0 lines, -194 lines 0 comments Download
D webrtc/libjingle/session/sessionmanager.cc View 1 chunk +0 lines, -309 lines 0 comments Download
D webrtc/libjingle/session/sessionmanagertask.h View 1 chunk +0 lines, -76 lines 0 comments Download
D webrtc/libjingle/session/sessionmessages.h View 1 chunk +0 lines, -226 lines 0 comments Download
D webrtc/libjingle/session/sessionmessages.cc View 1 chunk +0 lines, -1132 lines 0 comments Download
D webrtc/libjingle/session/sessionsendtask.h View 1 chunk +0 lines, -128 lines 0 comments Download
D webrtc/libjingle/tunnel/pseudotcpchannel.h View 1 chunk +0 lines, -140 lines 0 comments Download
D webrtc/libjingle/tunnel/pseudotcpchannel.cc View 1 chunk +0 lines, -603 lines 0 comments Download
D webrtc/libjingle/tunnel/securetunnelsessionclient.h View 1 chunk +0 lines, -165 lines 0 comments Download
D webrtc/libjingle/tunnel/securetunnelsessionclient.cc View 1 chunk +0 lines, -397 lines 0 comments Download
D webrtc/libjingle/tunnel/tunnelsessionclient.h View 1 chunk +0 lines, -182 lines 0 comments Download
D webrtc/libjingle/tunnel/tunnelsessionclient.cc View 1 chunk +0 lines, -432 lines 0 comments Download
D webrtc/libjingle/tunnel/tunnelsessionclient_unittest.cc View 1 chunk +0 lines, -226 lines 0 comments Download
A + webrtc/libjingle/xmllite/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/libjingle/xmpp/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
M webrtc/p2p/base/p2ptransport.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + webrtc/p2p/base/parsing.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/p2p/base/parsing.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/rawtransport.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/rawtransportchannel.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/session.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/p2p/base/session.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/session_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + webrtc/p2p/base/sessionclient.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/p2p/base/sessionmanager.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/p2p/base/sessionmanager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/p2p/base/sessionmessages.h View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/p2p/base/sessionmessages.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/p2p/base/transport.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/transport_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/p2p/client/sessionmanagertask.h View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/p2p/client/sessionsendtask.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/p2p.gyp View 3 chunks +9 lines, -6 lines 0 comments Download
Trybot results:
Project "webrtc" does not have a commit queue.

Messages

Total messages: 4 (1 generated)
pbos
Committed patchset #1 (id:1) manually as 7890 (presubmit successful).
4 years, 11 months ago (2014-12-15 07:04:58 UTC) #1
tommi
lgtm. thanks Peter
4 years, 11 months ago (2014-12-15 08:41:29 UTC) #2
kjellander
3 years, 9 months ago (2016-02-08 04:41:58 UTC) #4
Message was sent while issue was closed.
Found that some code becomes dead in this CL. I'm fixing it though
(https://codereview.webrtc.org/1678763002/).

https://webrtc-codereview.appspot.com/36439004/diff/1/all.gyp
File all.gyp (left):

https://webrtc-codereview.appspot.com/36439004/diff/1/all.gyp#oldcode24
all.gyp:24: 'webrtc/libjingle/libjingle.gyp:*',
Ouch, this essentially made webrtc/libjingle dead code. More code was moved
there in https://webrtc-codereview.appspot.com/32849004 and several more CLs,
but this line was never restored.

I'm restoring it in https://codereview.webrtc.org/1678763002/ for you!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted