WebRTC Code Reviews
Help | Chromium Project | Sign in
(10884)

Issue 39969004: Remove SSRCDatabase from RTPSender. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by pbos
Modified:
3 years, 9 months ago
Reviewers:
Stefan, mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry, Stefan, mflodman
Base URL:
http://webrtc.googlecode.com/svn/trunk
Project:
webrtc
Visibility:
Public.

Description

Remove SSRCDatabase from RTPSender. SSRCDatabase uses a static instance that shares SSRCs globally. Work is ongoing to remove static instances that aren't neccessary. SSRCs should be negotiated outside of the RTP module either way, so having a global database just complicates the code. R=mflodman@webrtc.org, stefan@webrtc.org BUG=4306

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -232 lines) Patch
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 3 chunks +0 lines, -21 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 3 chunks +0 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 7 chunks +2 lines, -30 lines 0 comments Download
D webrtc/modules/rtp_rtcp/source/ssrc_database.h View 1 chunk +0 lines, -53 lines 0 comments Download
D webrtc/modules/rtp_rtcp/source/ssrc_database.cc View 1 chunk +0 lines, -119 lines 0 comments Download
Project "webrtc" does not have a commit queue.

Messages

Total messages: 4 (0 generated)
pbos
PTAL, I'd like to get a verbal OK that this is probably a good thing ...
4 years, 9 months ago (2015-02-13 15:59:02 UTC) #1
tommi
On 2015/02/13 15:59:02, pbos wrote: > PTAL, I'd like to get a verbal OK that ...
4 years, 9 months ago (2015-02-14 07:45:53 UTC) #2
mflodman
I agree about doing this, but it needs more attention than just removing the database ...
4 years, 9 months ago (2015-02-16 09:17:26 UTC) #3
pbos
4 years, 9 months ago (2015-02-16 09:29:50 UTC) #4
On 2015/02/16 09:17:26, mflodman wrote:
> I agree about doing this, but it needs more attention than just removing the
> database as done in ps#1.
> 
> The initial ssrc should either be random or we need to make sure the user
> actually sets an ssrc. This is ok with the new API, but not the old API.
> 
> If an ssrc is always set from outside WebRTC, ssrc_forced_ should be removed.
> There is much more logic in both ViE and VoE than can be done much simpler if
> doing this.
> 
> Can you create a bug for this? So developers can track this work.
> 
> And I'm happy to discuss this.

https://code.google.com/p/webrtc/issues/detail?id=4306

I think I'll take a look later this week. Agreeing that ssrc_forced_ should go
away as well.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted