WebRTC Code Reviews
Help | Chromium Project | Sign in
(11969)

Issue 426002: Make gflags build for android (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by leozwang1
Modified:
1 year, 10 months ago
Reviewers:
vcgato29, kjellander
Base URL:
http://webrtc.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Make gflags build for android

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+816 lines, -0 lines) Patch
A third_party/google-gflags/gen/arch/android/arm/include/gflags/gflags.h View 1 2 1 chunk +585 lines, -0 lines 0 comments Download
A third_party/google-gflags/gen/arch/android/arm/include/gflags/gflags_completions.h View 1 2 1 chunk +121 lines, -0 lines 0 comments Download
A third_party/google-gflags/gen/arch/android/arm/include/private/config.h View 1 2 1 chunk +110 lines, -0 lines 0 comments Download
Trybot results:

Messages

Total messages: 7 (1 generated)
leozwang1
This patch makes gflags builds on android as well, please review.
7 years, 8 months ago (2012-03-01 07:33:59 UTC) #1
kjellander
On 2012/03/01 07:33:59, leozwang1 wrote: > This patch makes gflags builds on android as well, ...
7 years, 8 months ago (2012-03-01 09:57:54 UTC) #2
leozwang1
The ideas are borrowed from chromium/libvpx, normally linux/ia32, linux/arm, android/arm, android/ia32 can share same files. ...
7 years, 8 months ago (2012-03-01 15:05:59 UTC) #3
kjellander
LGTM. I don't really like the duplicated files solution either, but since they're already there ...
7 years, 8 months ago (2012-03-01 15:18:26 UTC) #4
leozwang1
Agree. thanks for reviewing.
7 years, 8 months ago (2012-03-01 15:26:35 UTC) #5
vcgato29
1 year, 10 months ago (2018-01-15 04:56:28 UTC) #7
Message was sent while issue was closed.
I am trying to install google-gflags on my android in terminal Id Because Follys
Installation requires if can anyone help
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted