Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
WebRTC Code Reviews
Help
|
Chromium Project
|
Sign in
(438)
Issues
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
44329004
: DO NOT COMMIT: aec nlp test-app
Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by
Bjorn
Modified:
5 years, 6 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.
More Reviews
Description
DO NOT COMMIT: aec nlp test-app webrtc#9495 BUG=
Patch Set 1
#
Patch Set 2 : Intermediate patch
#
Patch Set 3 : Issues with OpenSL ES
#
Patch Set 4 : Working, but low volume
#
Created:
5 years, 6 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+77 lines, -92 lines
)
Patch
M
webrtc/examples/android/media_demo/AndroidManifest.xml
View
1
2 chunks
+2 lines, -5 lines
0 comments
Download
M
webrtc/examples/android/media_demo/jni/voice_engine_jni.cc
View
1
2
3
1 chunk
+6 lines, -0 lines
0 comments
Download
M
webrtc/examples/android/media_demo/res/drawable/logo.png
View
1
Binary file
0 comments
Download
M
webrtc/examples/android/media_demo/res/layout/audiomenu.xml
View
1
2
2 chunks
+3 lines, -3 lines
0 comments
Download
M
webrtc/examples/android/media_demo/res/layout/mainmenu.xml
View
1
2
3
1 chunk
+1 line, -1 line
0 comments
Download
M
webrtc/examples/android/media_demo/res/layout/settingsmenu.xml
View
1
2
1 chunk
+1 line, -1 line
0 comments
Download
M
webrtc/examples/android/media_demo/res/menu/main_activity_actions.xml
View
1
2
1 chunk
+1 line, -1 line
0 comments
Download
M
webrtc/examples/android/media_demo/res/values/bools.xml
View
2
2 chunks
+2 lines, -2 lines
0 comments
Download
M
webrtc/examples/android/media_demo/res/values/integers.xml
View
1 chunk
+1 line, -1 line
0 comments
Download
M
webrtc/examples/android/media_demo/res/values/strings.xml
View
1
2
2 chunks
+5 lines, -3 lines
0 comments
Download
M
webrtc/examples/android/media_demo/src/org/webrtc/webrtcdemo/AudioMenuFragment.java
View
1
2
3 chunks
+2 lines, -39 lines
0 comments
Download
M
webrtc/examples/android/media_demo/src/org/webrtc/webrtcdemo/MainMenuFragment.java
View
1
2
3
3 chunks
+15 lines, -10 lines
0 comments
Download
M
webrtc/examples/android/media_demo/src/org/webrtc/webrtcdemo/MediaEngine.java
View
1
2
3
6 chunks
+20 lines, -7 lines
0 comments
Download
M
webrtc/examples/android/media_demo/src/org/webrtc/webrtcdemo/SettingsMenuFragment.java
View
1
2
3
2 chunks
+4 lines, -4 lines
0 comments
Download
M
webrtc/examples/android/media_demo/src/org/webrtc/webrtcdemo/VoiceEngine.java
View
2
3
2 chunks
+2 lines, -1 line
0 comments
Download
M
webrtc/examples/android/media_demo/src/org/webrtc/webrtcdemo/WebRTCDemo.java
View
1
2
3
5 chunks
+10 lines, -11 lines
0 comments
Download
M
webrtc/modules/audio_device/android/audio_manager.cc
View
1
2
3
1 chunk
+1 line, -2 lines
0 comments
Download
M
webrtc/modules/audio_device/android/audio_record_jni.cc
View
1
2
3
1 chunk
+1 line, -1 line
0 comments
Download
Trybot results:
More>>>
<<<Less
Sign in
to try more bots
Project "webrtc" does not have a commit queue.
Issue 44329004: DO NOT COMMIT: aec nlp test-app
Created 5 years, 8 months ago by Bjorn
Modified 5 years, 6 months ago
Reviewers:
Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Comments: 0
Recent Issues
|
This issue
This is Rietveld
245c2c2-tainted