Issue 46359004: BugFix: video capturer always uses the default 30 fps and didn't process maxFrameRate correctly whe…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 46359004: BugFix: video capturer always uses the default 30 fps and didn't process maxFrameRate correctly whe…

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 3 months ago by jeffw

Modified:
4 years ago

Reviewers:
tkchin

CC:
webrtc-reviews_webrtc.org, tterriberry, perkj, mflodman

Base URL:
https://chromium.googlesource.com/external/webrtc@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

BugFix: video capturer always uses the default 30 fps and didn't process maxFrameRate correctly when it is in RTCMediaConstraints. BUG=4668 Frame rate configuration on iOS doesn't be activated because the codes in function startCaptureInBackgroundWithOutput of rtc_video_capture_ios_objc.mm do not pass in the prorated frame rate into video capturer's configuration. Video capturer always run on the default value of the selected videoSupportedFrameRateRanges, such as 30 fps on iphone 5s. For example, if there is a maxFrameRate config with value 15 fps in the RTCMediaConstraints, the function will find the correct supported frame rate of the device, according to the maxFrameRate value. Rather than the prorated frame rate passed into activeVideoMaxFrameDuration, the default maxFrameDuration will be used wrongly.

Patch Set 1 #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -6 lines)			Patch
	M	webrtc/modules/video_capture/ios/rtc_video_capture_ios_objc.mm	View		1 chunk	+16 lines, -6 lines	0 comments	Download

Trybot results: Sign in to try more bots

Project "webrtc" does not have a commit queue.

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jeffw

4 years, 3 months ago (2015-05-19 06:53:00 UTC) #1

wangzhen263@gmail.com changed reviewers:
+ tkchin@webrtc.org

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages