WebRTC Code Reviews
Help | Chromium Project | Sign in
(41)

Issue 46359004: BugFix: video capturer always uses the default 30 fps and didn't process maxFrameRate correctly whe…

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by jeffw
Modified:
4 years ago
Reviewers:
tkchin
CC:
webrtc-reviews_webrtc.org, tterriberry, perkj, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

BugFix: video capturer always uses the default 30 fps and didn't process maxFrameRate correctly when it is in RTCMediaConstraints. BUG=4668 Frame rate configuration on iOS doesn't be activated because the codes in function startCaptureInBackgroundWithOutput of rtc_video_capture_ios_objc.mm do not pass in the prorated frame rate into video capturer's configuration. Video capturer always run on the default value of the selected videoSupportedFrameRateRanges, such as 30 fps on iphone 5s. For example, if there is a maxFrameRate config with value 15 fps in the RTCMediaConstraints, the function will find the correct supported frame rate of the device, according to the maxFrameRate value. Rather than the prorated frame rate passed into activeVideoMaxFrameDuration, the default maxFrameDuration will be used wrongly.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M webrtc/modules/video_capture/ios/rtc_video_capture_ios_objc.mm View 1 chunk +16 lines, -6 lines 0 comments Download
Trybot results: Sign in to try more bots
Project "webrtc" does not have a commit queue.

Messages

Total messages: 1 (1 generated)
jeffw
4 years, 3 months ago (2015-05-19 06:53:00 UTC) #1
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted