WebRTC Code Reviews
Help | Chromium Project | Sign in
(11963)

Issue 47269004: Remove set_flags() from PortAllocatorSession. Remove RawTransport. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by Sergey Ulanov
Modified:
3 years, 8 months ago
Reviewers:
pthatcher
CC:
webrtc-reviews_webrtc.org, tterriberry, Wez
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove set_flags() from PortAllocatorSession. Remove RawTransport. There are two ways flags can be set for PortAllocatorSession instances: parameter in the constructor and set_flags() method. But some flags must be passed to the constructor and have no effect with set_flags(). Removed set_flags() completely to avoid this issue in the future. Also removed RawTransport* - that code was using set_flags(), but it's not used anywhere.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -651 lines) Patch
M webrtc/libjingle/libjingle.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/libjingle/session/rawtransportparser.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M webrtc/p2p/base/portallocator.h View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/p2p/base/rawtransport.h View 1 chunk +0 lines, -46 lines 0 comments Download
D webrtc/p2p/base/rawtransport.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D webrtc/p2p/base/rawtransportchannel.h View 1 chunk +0 lines, -198 lines 0 comments Download
D webrtc/p2p/base/rawtransportchannel.cc View 1 chunk +0 lines, -260 lines 0 comments Download
M webrtc/p2p/client/portallocator_unittest.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M webrtc/p2p/p2p.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
Project "webrtc" does not have a commit queue.

Messages

Total messages: 3 (1 generated)
Sergey Ulanov
See https://codereview.chromium.org/1143893002 - that's an example of why set_flags() may be confusing.
4 years, 6 months ago (2015-05-20 21:08:20 UTC) #2
pthatcher
4 years, 6 months ago (2015-05-20 21:31:25 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted