Issue 49009004: NOT TO BE COMMITTED: Modified voe_cmd_test for saturation on Mac

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 49009004: NOT TO BE COMMITTED: Modified voe_cmd_test for saturation on Mac

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 4 months ago by Bjorn

Modified:
4 years, 1 month ago

Reviewers:

CC:
webrtc-reviews_webrtc.org, tterriberry, henrika_webrtc

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

NOT TO BE COMMITTED: Modified voe_cmd_test for saturation on Mac This CL modifies the voe_cmd_test by playing file locally and making a debug recording automatically to create consistent results (parts from what is actually being picked up by the mic). webrtc#9495 BUG=

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -23 lines)			Patch
	M	webrtc/modules/audio_device/mac/audio_device_mac.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	webrtc/voice_engine/test/cmd_test/voe_cmd_test.cc	View		13 chunks	+40 lines, -21 lines	0 comments	Download

Trybot results: Sign in to try more bots

Project "webrtc" does not have a commit queue.