Issue 49319004: Add thread checks to ChannelOwner. This is a part of cleaning up how references to channels are man…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 49319004: Add thread checks to ChannelOwner. This is a part of cleaning up how references to channels are man…

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 3 months ago by tommi

Modified:
4 years ago

Reviewers:

CC:
webrtc-reviews_webrtc.org, tterriberry, henrika_webrtc

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Add thread checks to ChannelOwner. This is a part of cleaning up how references to channels are managed in VoE. The ChannelOwner class can today cause channels to be deleted and unregistered on unpredicatble threads, which causes the ProcessThread implementation to have to implement locking. ChannelOwner is the only class that has this requirement and we've had deadlock problems in other implementations because of this. BUG=

Patch Set 1 #

Patch Set 2 : Adding checks for channel code... not working just yet but looks like we can do less locking #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Fix merge #

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -84 lines)			Patch
M	webrtc/voice_engine/channel.h	View	1 2 3 4 5	2 chunks	+30 lines, -13 lines	0 comments	Download
M	webrtc/voice_engine/channel.cc	View	1 2 3 4 5	22 chunks	+77 lines, -69 lines	0 comments	Download
M	webrtc/voice_engine/channel_manager.h	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
M	webrtc/voice_engine/channel_manager.cc	View	1 2	2 chunks	+9 lines, -2 lines	0 comments	Download

Trybot results: Sign in to try more bots

Project "webrtc" does not have a commit queue.

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tommi

Adding checks for channel code... not working just yet but looks like we can do ...

4 years, 3 months ago (2015-05-09 12:11:46 UTC) #1

Fix merge

Expand Messages | Collapse Messages