WebRTC Code Reviews
Help | Chromium Project | Sign in
(52)

Issue 49319004: Add thread checks to ChannelOwner. This is a part of cleaning up how references to channels are man…

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by tommi
Modified:
4 years ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry, henrika_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add thread checks to ChannelOwner. This is a part of cleaning up how references to channels are managed in VoE. The ChannelOwner class can today cause channels to be deleted and unregistered on unpredicatble threads, which causes the ProcessThread implementation to have to implement locking. ChannelOwner is the only class that has this requirement and we've had deadlock problems in other implementations because of this. BUG=

Patch Set 1 #

Patch Set 2 : Adding checks for channel code... not working just yet but looks like we can do less locking #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Fix merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -84 lines) Patch
M webrtc/voice_engine/channel.h View 1 2 3 4 5 2 chunks +30 lines, -13 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 2 3 4 5 22 chunks +77 lines, -69 lines 0 comments Download
M webrtc/voice_engine/channel_manager.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel_manager.cc View 1 2 2 chunks +9 lines, -2 lines 0 comments Download
Trybot results: Sign in to try more bots
Project "webrtc" does not have a commit queue.

Messages

Total messages: 6 (0 generated)
tommi
Adding checks for channel code... not working just yet but looks like we can do ...
4 years, 3 months ago (2015-05-09 12:11:46 UTC) #1
tommi
Rebase
4 years, 3 months ago (2015-05-13 21:51:31 UTC) #2
tommi
Rebase
4 years, 2 months ago (2015-05-25 09:14:45 UTC) #3
tommi
Rebase
4 years, 2 months ago (2015-05-29 15:19:05 UTC) #4
tommi
Rebase
4 years ago (2015-08-18 20:19:52 UTC) #5
tommi
4 years ago (2015-08-18 20:31:00 UTC) #6
Fix merge
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted