WebRTC Code Reviews
Help | Chromium Project | Sign in
(11970)

Issue 50049004: Remove VideoCodec::extra_options void pointer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by pbos
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie.mao, ajm, Stefan, tterriberry, qiang.lu, Niklas, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VideoCodec::extra_options void pointer. Removes webrtc::Config usage from vp8_impl.h, as well as temporal-layer factories. This also removes RealTimeTemporalLayers which isn't wired up. BUG= R=andresp@webrtc.org, mflodman@webrtc.org, stefan@webrtc.org

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -486 lines) Patch
M webrtc/common_types.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/default_temporal_layers.cc View 1 chunk +2 lines, -3 lines 0 comments Download
D webrtc/modules/video_coding/codecs/vp8/realtime_temporal_layers.cc View 1 chunk +0 lines, -268 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc View 2 chunks +0 lines, -29 lines 1 comment Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h View 2 chunks +0 lines, -103 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/temporal_layers.h View 2 chunks +3 lines, -18 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/main/source/codec_database.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/video_coding/main/source/video_sender_unittest.cc View 1 chunk +0 lines, -38 lines 0 comments Download
Project "webrtc" does not have a commit queue.

Messages

Total messages: 4 (0 generated)
pbos
PTAL, if you have any other suggestions of what to do with RealTimeTemporalLayers let me ...
4 years, 6 months ago (2015-05-22 15:00:40 UTC) #1
pbos
I also had to remove a test that required observing the temporal layers being created, ...
4 years, 6 months ago (2015-05-22 15:01:15 UTC) #2
pbos
https://review.webrtc.org/50049004/diff/1/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc File webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc (left): https://review.webrtc.org/50049004/diff/1/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc#oldcode94 webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc:94: // TL1 FrameDropper's max time to drop frames. I ...
4 years, 6 months ago (2015-05-22 15:02:56 UTC) #3
pbos
3 years, 10 months ago (2016-01-20 18:38:23 UTC) #4
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted