WebRTC Code Reviews
Help | Chromium Project | Sign in
(181)

Issue 50299004: Created SphericalPoint in array_util.h

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by bloch
Modified:
4 years, 1 month ago
Reviewers:
aluebs, ajm
CC:
webrtc-reviews_webrtc.org, ajm, tterriberry, HL, kwiberg, aluebs, Bjorn
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Created SphericalPoint in array_util.h Ran format Added namespace constants for IsInBeam Added comments Removed version control conflicts Added comments Fixed superfluous virtual added IsInBeam method BUG=

Patch Set 1 #

Patch Set 2 : Creating Spherical point #

Patch Set 3 : No IsInBeam method this time, remapped branches #

Patch Set 4 : removed extra beamformer.h file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M webrtc/modules/audio_processing/beamformer/array_util.h View 2 chunks +16 lines, -1 line 0 comments Download
Trybot results: Sign in to try more bots
Project "webrtc" does not have a commit queue.

Messages

Total messages: 4 (1 generated)
bloch
Created spherical point. I included the IsInBeam method as well.
4 years, 1 month ago (2015-06-24 21:26:29 UTC) #1
bloch
On 2015/06/24 21:26:29, bloch wrote: > Created spherical point. I included the IsInBeam method as ...
4 years, 1 month ago (2015-06-25 00:22:02 UTC) #2
bloch
4 years, 1 month ago (2015-06-25 00:22:58 UTC) #4
Removed the IsInBeam method. CL should be neater now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted