Issue 50299004: Created SphericalPoint in array_util.h

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 50299004: Created SphericalPoint in array_util.h

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 6 months ago by bloch

Modified:
5 years, 6 months ago

Reviewers:
aluebs, ajm

CC:
webrtc-reviews_webrtc.org, ajm, tterriberry, HL, kwiberg, aluebs, Bjorn

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Created SphericalPoint in array_util.h Ran format Added namespace constants for IsInBeam Added comments Removed version control conflicts Added comments Fixed superfluous virtual added IsInBeam method BUG=

Patch Set 1 #

Patch Set 2 : Creating Spherical point #

Patch Set 3 : No IsInBeam method this time, remapped branches #

Patch Set 4 : removed extra beamformer.h file #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	webrtc/modules/audio_processing/beamformer/array_util.h	View		2 chunks	+16 lines, -1 line	0 comments	Download

Trybot results: Sign in to try more bots

Project "webrtc" does not have a commit queue.

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

bloch

Created spherical point. I included the IsInBeam method as well.

5 years, 6 months ago (2015-06-24 21:26:29 UTC) #1

bloch

On 2015/06/24 21:26:29, bloch wrote: > Created spherical point. I included the IsInBeam method as ...

5 years, 6 months ago (2015-06-25 00:22:02 UTC) #2

Removed the IsInBeam method. CL should be neater now.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages