WebRTC Code Reviews
Help | Chromium Project | Sign in
(10879)

Issue 51129004: Remove webrtc::Config from ChannelGroup. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by pbos
Modified:
3 years, 11 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie.mao, ajm, Stefan, tterriberry, qiang.lu, Niklas, andresp-webrtc, perkj, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove webrtc::Config from ChannelGroup. Removes webrtc/experiments.h and Config arguments (that were unused) from ViEChannel and ViEEncoder. BUG=1695 R=mflodman@webrtc.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -72 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/experiments.h View 1 chunk +0 lines, -33 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video_engine/encoder_state_feedback_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/video_engine/vie_channel.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/video_engine/vie_channel.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/video_engine/vie_channel_group.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/video_engine/vie_channel_group.cc View 7 chunks +17 lines, -23 lines 0 comments Download
M webrtc/video_engine/vie_encoder.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/video_engine/vie_encoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/webrtc.gyp View 1 chunk +0 lines, -1 line 0 comments Download
Project "webrtc" does not have a commit queue.

Messages

Total messages: 1 (0 generated)
pbos
4 years, 5 months ago (2015-05-28 12:41:30 UTC) #1
PTAL, I thought this would be harder but the config wasn't really propagated
deeper.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted