WebRTC Code Reviews
Help | Chromium Project | Sign in
(262)

Issue 51339004: Fix return type to be void.

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by dskiba
Modified:
1 year, 9 months ago
Reviewers:
kjellander, rtoy
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc/deps/third_party/openmax.git@master
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix return type to be void. Missing return type causes warning (which is treated as an error) when compiling with Clang. BUG=chromium:539781

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M dl/sp/src/arm/arm64/omxSP_FFTInv_CCSToR_F32.c View 1 chunk +1 line, -1 line 0 comments Download
M dl/sp/src/arm/arm64/omxSP_FFTInv_CToC_FC32.c View 1 chunk +1 line, -1 line 0 comments Download
Trybot results: Sign in to try more bots
Project "webrtc" does not have a commit queue.

Messages

Total messages: 17 (2 generated)
dskiba
1 year, 9 months ago (2016-01-06 22:16:05 UTC) #2
rtoy
lgtm. Before landing, can you update the BUG entry to chromium:539781 so that clicking it ...
1 year, 9 months ago (2016-01-06 22:22:24 UTC) #3
dskiba
Hmm, should I use 'git cl land'? It fails with error: failed to push some ...
1 year, 9 months ago (2016-01-06 22:54:54 UTC) #4
rtoy
On 2016/01/06 22:54:54, dskiba wrote: > Hmm, should I use 'git cl land'? It fails ...
1 year, 9 months ago (2016-01-06 23:14:29 UTC) #5
dskiba
On 2016/01/06 23:14:29, rtoy wrote: > On 2016/01/06 22:54:54, dskiba wrote: > > Hmm, should ...
1 year, 9 months ago (2016-01-08 18:54:49 UTC) #6
rtoy
On 2016/01/08 18:54:49, dskiba wrote: > On 2016/01/06 23:14:29, rtoy wrote: > > On 2016/01/06 ...
1 year, 9 months ago (2016-01-08 19:06:46 UTC) #7
dskiba
On 2016/01/08 19:06:46, rtoy wrote: > On 2016/01/08 18:54:49, dskiba wrote: > > On 2016/01/06 ...
1 year, 9 months ago (2016-01-08 19:23:10 UTC) #8
rtoy
On 2016/01/08 19:23:10, dskiba wrote: > On 2016/01/08 19:06:46, rtoy wrote: > > On 2016/01/08 ...
1 year, 9 months ago (2016-01-08 22:37:45 UTC) #9
rtoy
+kjellander for codereview.settings question.
1 year, 9 months ago (2016-01-08 22:38:25 UTC) #11
dskiba
On 2016/01/08 22:37:45, rtoy wrote: > On 2016/01/08 19:23:10, dskiba wrote: > > On 2016/01/08 ...
1 year, 9 months ago (2016-01-08 22:41:27 UTC) #12
rtoy
On 2016/01/08 22:41:27, dskiba wrote: > On 2016/01/08 22:37:45, rtoy wrote: > > On 2016/01/08 ...
1 year, 9 months ago (2016-01-08 23:05:19 UTC) #13
dskiba
On 2016/01/08 23:05:19, rtoy wrote: > On 2016/01/08 22:41:27, dskiba wrote: > > On 2016/01/08 ...
1 year, 9 months ago (2016-01-08 23:10:40 UTC) #14
rtoy
On 2016/01/08 23:10:40, dskiba wrote: > On 2016/01/08 23:05:19, rtoy wrote: > > On 2016/01/08 ...
1 year, 9 months ago (2016-01-08 23:14:40 UTC) #15
dskiba
On 2016/01/08 23:14:40, rtoy wrote: > On 2016/01/08 23:10:40, dskiba wrote: > > On 2016/01/08 ...
1 year, 9 months ago (2016-01-08 23:18:25 UTC) #16
kjellander
1 year, 9 months ago (2016-01-10 05:57:31 UTC) #17
The codereview.settings file is correct so I wonder how your CL was created on
the old code review site since we switched a long time ago.

Since the code review settings are stored on a per-branch basis in Git. Can you
try to sync your master, create a new local branch, patch it with these changes
and do a new "git cl upload" from it?

Then you should end up with a CL at https://codereview.webrtc.org/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted