WebRTC Code Reviews
Help | Chromium Project | Sign in
(8)

Issue 52679004: Update mac/avf video capture implementation.

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by dongyanglichn
Modified:
1 year, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry, perkj, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add AVfoundation video capture support on Mac . mac/qtkit do not support ARC. And the gyp is generally not possible to define some rules to override the compile flag for single files. Add two target as the video capture implementation of mac.(QTkit/AVFoundation) the AVFoundation implementation to the mac os is basically a slightly changed version of iOS video capture module with a few iOS specific items. BUG=3968 TEST=none

Patch Set 1 #

Patch Set 2 : Add author. #

Total comments: 7

Patch Set 3 : Update mac/avf video capture implementation. #

Total comments: 4

Patch Set 4 : #

Patch Set 5 : Update gyp to disable --Wpartial-availability flag. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -188 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_capture/BUILD.gn View 1 2 2 chunks +52 lines, -13 lines 0 comments Download
A + webrtc/modules/video_capture/mac/avf/device_info_avf.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + webrtc/modules/video_capture/mac/avf/device_info_avf.mm View 1 2 6 chunks +26 lines, -27 lines 0 comments Download
A + webrtc/modules/video_capture/mac/avf/device_info_avf_objc.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/video_capture/mac/avf/device_info_avf_objc.mm View 1 2 3 4 5 chunks +21 lines, -12 lines 0 comments Download
A + webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.h View 1 2 3 2 chunks +7 lines, -9 lines 0 comments Download
A + webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.mm View 1 2 3 4 11 chunks +26 lines, -71 lines 0 comments Download
A + webrtc/modules/video_capture/mac/avf/video_capture_avf.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + webrtc/modules/video_capture/mac/avf/video_capture_avf.mm View 1 2 7 chunks +13 lines, -14 lines 0 comments Download
A webrtc/modules/video_capture/mac/video_capture_mac.gypi View 1 2 3 4 1 chunk +76 lines, -0 lines 0 comments Download
M webrtc/modules/video_capture/mac/video_capture_mac.mm View 1 2 3 4 5 chunks +26 lines, -5 lines 0 comments Download
M webrtc/modules/video_capture/video_capture.gypi View 1 2 3 4 2 chunks +7 lines, -19 lines 0 comments Download
Trybot results: Sign in to try more bots
Project "webrtc" does not have a commit queue.

Messages

Total messages: 24 (7 generated)
dongyanglichn
1 year, 9 months ago (2015-06-04 10:48:01 UTC) #2
kjellander
Thanks a lot for this contribution Andrew, it looks very promising. I'm handing this over ...
1 year, 9 months ago (2015-06-04 11:34:19 UTC) #4
dongyanglichn
On 2015/06/04 11:34:19, kjellander wrote: > Thanks a lot for this contribution Andrew, it looks ...
1 year, 9 months ago (2015-06-05 02:50:40 UTC) #5
magjed
Is the plan to remove webrtc/modules/video_capture/ios in a follow-up CL? Also, in issue 3968, someone ...
1 year, 9 months ago (2015-06-05 10:16:25 UTC) #6
dongyanglichn
On 2015/06/05 10:16:25, magjed wrote: > Is the plan to remove webrtc/modules/video_capture/ios in a follow-up ...
1 year, 9 months ago (2015-06-08 12:06:58 UTC) #7
dongyanglichn
On 2015/06/08 12:06:58, dongyanglichn wrote: > On 2015/06/05 10:16:25, magjed wrote: > > Is the ...
1 year, 9 months ago (2015-06-11 06:20:27 UTC) #8
dongyanglichn
https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/video_capture/mac/avf/device_info_avf.mm File webrtc/modules/video_capture/mac/avf/device_info_avf.mm (right): https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/video_capture/mac/avf/device_info_avf.mm#newcode30 webrtc/modules/video_capture/mac/avf/device_info_avf.mm:30: /*AVCaptureSessionPreset1920x1080*/]; On 2015/06/05 10:16:24, magjed wrote: > Why can't ...
1 year, 9 months ago (2015-06-12 05:55:04 UTC) #11
magjed
I see you have disabled the orientation notifications for iOS. Is the plan still to ...
1 year, 9 months ago (2015-06-12 08:55:27 UTC) #12
dongyanglichn
* Keep webrtc/modules/video_capture/ios * Add webrtc/modules/video_capture/mac/avf * Disabled the orientation notifications for Mac https://webrtc-codereview.appspot.com/52679004/diff/80001/webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.h File ...
1 year, 9 months ago (2015-06-15 03:57:08 UTC) #13
dongyanglichn
* Keep webrtc/modules/video_capture/ios * Add webrtc/modules/video_capture/mac/avf * Disabled the orientation notifications for Mac
1 year, 9 months ago (2015-06-15 03:57:10 UTC) #14
dongyanglichn
Hi,there is no update about two week. I think there may be a better way ...
1 year, 9 months ago (2015-06-27 03:35:39 UTC) #15
dongyanglichn
1 year, 8 months ago (2015-07-17 08:00:30 UTC) #16
dongyanglichn
On 2015/07/17 08:00:30, dongyanglichn wrote: This patch does not remove webrtc/modules/video_capture/ios.And the ios implementation is ...
1 year, 8 months ago (2015-07-29 03:38:57 UTC) #17
dongyanglichn
1 year, 8 months ago (2015-07-29 03:41:47 UTC) #19
dongyanglichn
fetch the latest code fro the upstream. I fixed the build error by disabling the ...
1 year, 8 months ago (2015-07-29 07:53:31 UTC) #20
dongyanglichn
1 year, 8 months ago (2015-07-29 08:05:36 UTC) #22
dongyanglichn
1 year, 8 months ago (2015-07-29 08:08:06 UTC) #24

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted