Update mac/avf video capture implementation.

Add AVfoundation video capture support on Mac .
mac/qtkit do not support ARC. And the gyp is generally not possible to define some rules to override the compile flag for single files.
Add two target as the video capture implementation of mac.(QTkit/AVFoundation)
the AVFoundation implementation to the mac os is basically a slightly changed version of iOS video capture module with a few iOS specific items.

BUG=3968
TEST=none

[dongyanglichn, 2015-06-04 10:48:01]

dongyang.li.chn@gmail.com changed reviewers:
+ kjellander@webrtc.org

[kjellander, 2015-06-04 11:34:19]

kjellander@webrtc.org changed reviewers:
+ magjed@webrtc.org

[kjellander, 2015-06-04 11:34:19]

Thanks a lot for this contribution Andrew, it looks very promising.

I'm handing this over to magjed@ for review, since I know to little about this
area.

[dongyanglichn, 2015-06-05 02:50:40]

On 2015/06/04 11:34:19, kjellander wrote:
> Thanks a lot for this contribution Andrew, it looks very promising.
> 
> I'm handing this over to magjed@ for review, since I know to little about this
> area.

Ok,thanks.

[magjed, 2015-06-05 10:16:25]

Is the plan to remove webrtc/modules/video_capture/ios in a follow-up CL? Also,
in issue 3968, someone mentioned that it would always capture in 1280x720. Has
that been fixed now? Also, why can’t we support 1920x1080 for non-iOS? Other
than that, this CL looks good to me.

https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
File webrtc/modules/video_capture/mac/avf/device_info_avf.mm (right):

https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
webrtc/modules/video_capture/mac/avf/device_info_avf.mm:30:
/*AVCaptureSessionPreset1920x1080*/];
Why can't we check for 1080p support anymore? If it's not supported, then
[avDevice supportsAVCaptureSessionPreset] should simply return false?

https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
File webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.h (right):

https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.h:16: #import
<UIKit/UIKit.h>
Do we need this import at all?

https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
File webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.mm (right):

https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.mm:98: #endif
Remove all indentation for #endif.

https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.mm:114: #if
defined(WEBRTC_IOS)
Remove indentation. Also, move this one line down.

https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.mm:152: #if
defined(WEBRTC_IOS)
Is this #if-guard really needed? What happens for non-iOS?

[dongyanglichn, 2015-06-08 12:06:58]

On 2015/06/05 10:16:25, magjed wrote:
> Is the plan to remove webrtc/modules/video_capture/ios in a follow-up CL?
Also,
> in issue 3968, someone mentioned that it would always capture in 1280x720. Has
> that been fixed now? Also, why can’t we support 1920x1080 for non-iOS? Other
> than that, this CL looks good to me.
> 
>
https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
> File webrtc/modules/video_capture/mac/avf/device_info_avf.mm (right):
> 
>
https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
> webrtc/modules/video_capture/mac/avf/device_info_avf.mm:30:
> /*AVCaptureSessionPreset1920x1080*/];
> Why can't we check for 1080p support anymore? If it's not supported, then
> [avDevice supportsAVCaptureSessionPreset] should simply return false?
> 
>
https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
> File webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.h
(right):
> 
>
https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
> webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.h:16: #import
> <UIKit/UIKit.h>
> Do we need this import at all?
> 
>
https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
> File webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.mm
(right):
> 
>
https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
> webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.mm:98: #endif
> Remove all indentation for #endif.
> 
>
https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
> webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.mm:114: #if
> defined(WEBRTC_IOS)
> Remove indentation. Also, move this one line down.
> 
>
https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
> webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.mm:152: #if
> defined(WEBRTC_IOS)
> Is this #if-guard really needed? What happens for non-iOS?

Thanks.Yes,
#1.I plan to remove the video capture module of iOS in the in a follow-up CL.
And the video capture in chromium does not have a iOS module.
I think iOS/Mac should share the implementation of video capture based on
AVFoundation.
#2.This CL simply disabled the iOS specified items.I will test for non-iOS video
capture with more details later,1080p and #if-guard condition.
Soon,I'll update the CL.

[dongyanglichn, 2015-06-11 06:20:27]

On 2015/06/08 12:06:58, dongyanglichn wrote:
> On 2015/06/05 10:16:25, magjed wrote:
> > Is the plan to remove webrtc/modules/video_capture/ios in a follow-up CL?
> Also,
> > in issue 3968, someone mentioned that it would always capture in 1280x720.
Has
> > that been fixed now? Also, why can’t we support 1920x1080 for non-iOS? Other
> > than that, this CL looks good to me.
> > 
> >
>
https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
> > File webrtc/modules/video_capture/mac/avf/device_info_avf.mm (right):
> > 
> >
>
https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
> > webrtc/modules/video_capture/mac/avf/device_info_avf.mm:30:
> > /*AVCaptureSessionPreset1920x1080*/];
> > Why can't we check for 1080p support anymore? If it's not supported, then
> > [avDevice supportsAVCaptureSessionPreset] should simply return false?
> > 
> >
>
https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
> > File webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.h
> (right):
> > 
> >
>
https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
> > webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.h:16:
#import
> > <UIKit/UIKit.h>
> > Do we need this import at all?
> > 
> >
>
https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
> > File webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.mm
> (right):
> > 
> >
>
https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
> > webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.mm:98:
#endif
> > Remove all indentation for #endif.
> > 
> >
>
https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
> > webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.mm:114: #if
> > defined(WEBRTC_IOS)
> > Remove indentation. Also, move this one line down.
> > 
> >
>
https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
> > webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.mm:152: #if
> > defined(WEBRTC_IOS)
> > Is this #if-guard really needed? What happens for non-iOS?
> 
> Thanks.Yes,
> #1.I plan to remove the video capture module of iOS in the in a follow-up CL.
> And the video capture in chromium does not have a iOS module.
> I think iOS/Mac should share the implementation of video capture based on
> AVFoundation.
> #2.This CL simply disabled the iOS specified items.I will test for non-iOS
video
> capture with more details later,1080p and #if-guard condition.
> Soon,I'll update the CL.

Update the CL. remove all iOS specific items.
Finally，I have not removed  "webrtc/modules/video_capture/ios" .
The iOS has to deal with video orientation.
The CL also add capabilities mentioned in apple AVFoundation dev doc.

I can't reproduce the problem someone mentioned .It works well for me when I
change the capture preset.
Well,Face time HD camera supports 720p.But,AVFoundation for mac does not have
1920x1080p video format preset constant.
We can capture video with FULL HD.
The problem is that we can't check directly using
AVCaptureSessionPreset1920x1080 which is designed for iOS.
Hope the updated patch will solve capture problems on Mac.

Best.

[dongyanglichn, 2015-06-11 08:27:55]

Patchset #3 (id:40001) has been deleted

[dongyanglichn, 2015-06-12 05:53:23]

Patchset #3 (id:60001) has been deleted

[dongyanglichn, 2015-06-12 05:55:04]

https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
File webrtc/modules/video_capture/mac/avf/device_info_avf.mm (right):

https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
webrtc/modules/video_capture/mac/avf/device_info_avf.mm:30:
/*AVCaptureSessionPreset1920x1080*/];
On 2015/06/05 10:16:24, magjed wrote:
> Why can't we check for 1080p support anymore? If it's not supported, then
> [avDevice supportsAVCaptureSessionPreset] should simply return false?
> 
on OS X,there is no constant string defined like
AVCaptureSessionPreset1920x1080.
capture settings presets available :
https://developer.apple.com/library/mac/documentation/AVFoundation/Reference/...

So,I think we don't need to check for 1080p.

https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
File webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.h (right):

https://webrtc-codereview.appspot.com/52679004/diff/20001/webrtc/modules/vide...
webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.h:16: #import
<UIKit/UIKit.h>
On 2015/06/05 10:16:24, magjed wrote:
> Do we need this import at all?

We do not need to import it any more.I'll remove it for video capture on Mac.

[magjed, 2015-06-12 08:55:27]

I see you have disabled the orientation notifications for iOS. Is the plan still
to remove webrtc/modules/video_capture/ios in a follow-up CL? How will you fix
the orientation notifications in that case?

https://webrtc-codereview.appspot.com/52679004/diff/80001/webrtc/modules/vide...
File webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.h (right):

https://webrtc-codereview.appspot.com/52679004/diff/80001/webrtc/modules/vide...
webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.h:15: 
nit: Remove trailing whitespace

https://webrtc-codereview.appspot.com/52679004/diff/80001/webrtc/modules/vide...
File webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.mm (right):

https://webrtc-codereview.appspot.com/52679004/diff/80001/webrtc/modules/vide...
webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.mm:126: if
([_captureSession
nit: Indentation - remove one space here.

[dongyanglichn, 2015-06-15 03:57:08]

* Keep webrtc/modules/video_capture/ios
* Add webrtc/modules/video_capture/mac/avf
* Disabled the orientation notifications for Mac

https://webrtc-codereview.appspot.com/52679004/diff/80001/webrtc/modules/vide...
File webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.h (right):

https://webrtc-codereview.appspot.com/52679004/diff/80001/webrtc/modules/vide...
webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.h:15: 
On 2015/06/12 08:55:27, magjed wrote:
> nit: Remove trailing whitespace

Done.

https://webrtc-codereview.appspot.com/52679004/diff/80001/webrtc/modules/vide...
File webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.mm (right):

https://webrtc-codereview.appspot.com/52679004/diff/80001/webrtc/modules/vide...
webrtc/modules/video_capture/mac/avf/rtc_video_capture_avf_objc.mm:126: if
([_captureSession
On 2015/06/12 08:55:27, magjed wrote:
> nit: Indentation - remove one space here.

Done.

[dongyanglichn, 2015-06-15 03:57:10]

* Keep webrtc/modules/video_capture/ios
* Add webrtc/modules/video_capture/mac/avf
* Disabled the orientation notifications for Mac

[dongyanglichn, 2015-06-27 03:35:39]

Hi,there is no update about two week.
I think there may be a better way to add AVFoundation support for Mac.I have not
removed iOS video capture implementation.Add I added Mac's own video capture
implementation. If you have any advice,please let me know.
I will try to update this patch.Thanks.

[dongyanglichn, 2015-07-29 03:38:57]

On 2015/07/17 08:00:30, dongyanglichn wrote:

This patch does not remove webrtc/modules/video_capture/ios.And the ios
implementation is untouched. 
I disabled the orientation notifcation for Mac not iOS.

[dongyanglichn, 2015-07-29 03:41:46]

dongyang.li.chn@gmail.com changed required reviewers:
+ magjed@webrtc.org

[dongyanglichn, 2015-07-29 07:53:31]

fetch the latest code fro the upstream.
I fixed the build error by disabling the -Wpartial-availability flag.
Since AVFoundation introduced in OSX 10.7.
Please review.

[dongyanglichn, 2015-07-29 08:05:36]

dongyang.li.chn@gmail.com changed reviewers:
+ perkj@webrtc.org

[dongyanglichn, 2015-07-29 08:08:06]

dongyang.li.chn@gmail.com changed reviewers:
+ mflodman@webrtc.org