WebRTC Code Reviews
Help | Chromium Project | Sign in
(1273)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 54499005: H.264 codec support with OpenH264 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by hbos
Modified:
3 years, 7 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, yujie.mao, ajm, Stefan, tterriberry, qiang.lu, Niklas, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

--- Moving this work to codereview.webrtc.org: https://codereview.webrtc.org/1306813009 --- H.264 codec support with OpenH264 WIP See also: - Stefan's old CL with OpenH264: https://review.webrtc.org/17839004/ - OpenH264 in Chrome: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/ffmpeg/libavcodec/libopenh264enc.c

Patch Set 1 : OpenH264 library added (but .gitignore'd) and .gyp dependencies updated #

Patch Set 2 : H264Encoder,-Impl, H264Decoder,-Impl files, to be implemented #

Patch Set 3 : H264EncoderImpl implemented (untested, possibly incomplete and buggy) #

Patch Set 4 : H264DecoderImpl implemented (untested, possibly incomplete and buggy) #

Patch Set 5 : H264 encoder/decoder creation (todo: Chrome/RTCVideo[En/De]coderFactory) #

Patch Set 6 : Added unittest, trying to get decode to work... #

Patch Set 7 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1110 lines, -33 lines) Patch
M talk/media/webrtc/webrtcvideoengine2.cc View 1 2 3 4 5 3 chunks +14 lines, -5 lines 0 comments Download
M webrtc/build/common.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/engine_configurations.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/modules.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 2 3 4 5 2 chunks +26 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/.gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/h264.gyp View 1 1 chunk +57 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.h View 1 2 3 4 5 6 1 chunk +66 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc View 1 2 3 4 5 6 1 chunk +191 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h View 1 2 3 4 5 6 1 chunk +83 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 1 2 3 4 5 6 1 chunk +555 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/include/h264.h View 1 2 3 4 5 1 chunk +37 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 1 2 3 4 5 2 chunks +7 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/main/source/codec_database.cc View 1 2 3 4 5 6 chunks +31 lines, -16 lines 0 comments Download
M webrtc/modules/video_coding/video_coding.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/encoder_settings.cc View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 2 3 4 5 5 chunks +13 lines, -6 lines 0 comments Download
M webrtc/video/loopback.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/video/video_decoder.cc View 1 2 3 4 3 chunks +5 lines, -0 lines 0 comments Download
M webrtc/video/video_encoder.cc View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/video_decoder.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video_encoder.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/webrtc.gyp View 1 chunk +1 line, -0 lines 0 comments Download
Trybot results:
Project "webrtc" does not have a commit queue.

Messages

Total messages: 3 (1 generated)
cm.sanchi
On 2015/06/01 11:41:52, hbos wrote: > Patchset #6 (id:100001) has been deleted Hi, Any plans ...
3 years, 8 months ago (2015-08-11 13:40:03 UTC) #2
hbos
3 years, 8 months ago (2015-08-12 10:20:06 UTC) #3 
On 2015/08/11 13:40:03, cm.sanchi wrote:
> On 2015/06/01 11:41:52, hbos wrote:
> > Patchset #6 (id:100001) has been deleted
> 
> Hi,
> 
> Any plans to support H264 on Android?

Hello. For any questions and discussion regarding webrtc, please go to the
discuss-webrtc google group (this is a code review website and not a forum,
sorry!). :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted