WebRTC Code Reviews
Help | Chromium Project | Sign in
(2733)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 54789004: Added -Wno-tautological-compare to voice_engine

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 2 months ago by ckulakowski
Modified:
3 years, 8 months ago
Reviewers:
kjellander, ajm
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git@master
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added -Wno-tautological-compare to voice_engine LOG_F generates warning with some severity setting.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M voice_engine/voice_engine.gyp View 1 chunk +6 lines, -0 lines 1 comment Download
Trybot results: Sign in to try more bots
Project "webrtc" does not have a commit queue.

Messages

Total messages: 7 (2 generated)
ckulakowski
Without this compilation parameter LOG_F generates warning with some severity setting.
5 years, 2 months ago (2015-07-07 09:55:07 UTC) #2
ckulakowski
On 2015/07/07 09:55:07, ckulakowski wrote: > Without this compilation parameter LOG_F generates warning with some ...
5 years, 2 months ago (2015-07-07 09:56:39 UTC) #3
kjellander
On 2015/07/07 09:56:39, ckulakowski wrote: > On 2015/07/07 09:55:07, ckulakowski wrote: > > Without this ...
5 years, 2 months ago (2015-07-07 11:14:43 UTC) #4
ajm
Drive-by. https://webrtc-codereview.appspot.com/54789004/diff/1/voice_engine/voice_engine.gyp File voice_engine/voice_engine.gyp (right): https://webrtc-codereview.appspot.com/54789004/diff/1/voice_engine/voice_engine.gyp#newcode32 voice_engine/voice_engine.gyp:32: '-Wno-tautological-compare', Is it possible to fix the LOG_F ...
5 years, 2 months ago (2015-07-07 17:18:09 UTC) #6
bratell at opera
5 years ago (2015-09-11 07:54:01 UTC) #7 
On 2015/07/07 17:18:09, ajm wrote:
> Drive-by.
> 
>
https://webrtc-codereview.appspot.com/54789004/diff/1/voice_engine/voice_engi...
> File voice_engine/voice_engine.gyp (right):
> 
>
https://webrtc-codereview.appspot.com/54789004/diff/1/voice_engine/voice_engi...
> voice_engine/voice_engine.gyp:32: '-Wno-tautological-compare',
> Is it possible to fix the LOG_F macro instead?

I guess the problem is RESTRICT_LOGGING_PRECONDITION(sev) which expands to

"sev < webrtc::LS_INFO ? (void) 0 :"

This doesn't seem that strange except for the two-thirds of a tertiary
condition. Maybe that is why the compiler warns here and not everywhere. Or
maybe everywhere else uses the flag this patch is adding.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted