On 2015/07/07 09:55:07, ckulakowski wrote: > Without this compilation parameter LOG_F generates warning with some ...
5 years, 9 months ago
(2015-07-07 09:56:39 UTC)
#3
On 2015/07/07 09:55:07, ckulakowski wrote:
> Without this compilation parameter LOG_F generates warning with some severity
> setting.
To be more exact: LOG_F generates warning "self-comparison always evaluates to
false".
On 2015/07/07 09:56:39, ckulakowski wrote: > On 2015/07/07 09:55:07, ckulakowski wrote: > > Without this ...
5 years, 9 months ago
(2015-07-07 11:14:43 UTC)
#4
On 2015/07/07 09:56:39, ckulakowski wrote:
> On 2015/07/07 09:55:07, ckulakowski wrote:
> > Without this compilation parameter LOG_F generates warning with some
severity
> > setting.
>
> To be more exact: LOG_F generates warning "self-comparison always evaluates to
> false".
Please update your checkout and create a new CL on https://codereview.webrtc.org
instead. Then please pick henrikg@webrtc.org or henrika@webrtc.org as reviewer
as I'm OOO for 8 more weeks.
Drive-by. https://webrtc-codereview.appspot.com/54789004/diff/1/voice_engine/voice_engine.gyp File voice_engine/voice_engine.gyp (right): https://webrtc-codereview.appspot.com/54789004/diff/1/voice_engine/voice_engine.gyp#newcode32 voice_engine/voice_engine.gyp:32: '-Wno-tautological-compare', Is it possible to fix the LOG_F ...
5 years, 9 months ago
(2015-07-07 17:18:09 UTC)
#6
5 years, 7 months ago
(2015-09-11 07:54:01 UTC)
#7
On 2015/07/07 17:18:09, ajm wrote:
> Drive-by.
>
>
https://webrtc-codereview.appspot.com/54789004/diff/1/voice_engine/voice_engi...
> File voice_engine/voice_engine.gyp (right):
>
>
https://webrtc-codereview.appspot.com/54789004/diff/1/voice_engine/voice_engi...
> voice_engine/voice_engine.gyp:32: '-Wno-tautological-compare',
> Is it possible to fix the LOG_F macro instead?
I guess the problem is RESTRICT_LOGGING_PRECONDITION(sev) which expands to
"sev < webrtc::LS_INFO ? (void) 0 :"
This doesn't seem that strange except for the two-thirds of a tertiary
condition. Maybe that is why the compiler warns here and not everywhere. Or
maybe everywhere else uses the flag this patch is adding.
Issue 54789004: Added -Wno-tautological-compare to voice_engine
Created 5 years, 9 months ago by ckulakowski
Modified 4 years, 3 months ago
Reviewers: kjellander, ajm
Base URL: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git@master
Comments: 1