WebRTC Code Reviews
Help | Chromium Project | Sign in
(10882)

Issue 55489004: Remove base channels + receiver ViEEncoder. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by pbos
Modified:
3 years, 11 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, yujie.mao, Stefan, tterriberry, andresp-webrtc, perkj, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove base channels + receiver ViEEncoder. Removes receiver dependencies on a ViEEncoder, and the need to create one in Call. Also contains cleanup (removing dead code, simplifying code now that ViEEncoder maps to one Channel). BUG=1695, chromium:491112 R=mflodman@webrtc.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -173 lines) Patch
M webrtc/video/call.cc View 5 chunks +2 lines, -10 lines 0 comments Download
M webrtc/video/video_receive_stream.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/video_receive_stream.cc View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_engine/vie_channel.h View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/video_engine/vie_channel.cc View 4 chunks +3 lines, -6 lines 0 comments Download
M webrtc/video_engine/vie_channel_group.h View 2 chunks +1 line, -16 lines 0 comments Download
M webrtc/video_engine/vie_channel_group.cc View 10 chunks +13 lines, -110 lines 0 comments Download
M webrtc/video_engine/vie_defines.h View 1 chunk +0 lines, -22 lines 0 comments Download
M webrtc/video_engine/vie_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download
Project "webrtc" does not have a commit queue.

Messages

Total messages: 3 (0 generated)
pbos
PTAL! This might trigger https://code.google.com/p/chromium/issues/detail?id=491112, if not we can narrow down the search. Either way ...
4 years, 5 months ago (2015-05-26 10:23:53 UTC) #1
pbos
On 2015/05/26 10:23:53, pbos wrote: > PTAL! > > This might trigger https://code.google.com/p/chromium/issues/detail?id=491112, > if ...
4 years, 5 months ago (2015-05-26 10:32:53 UTC) #2
pbos
4 years, 5 months ago (2015-05-26 10:43:38 UTC) #3
On 2015/05/26 10:32:53, pbos wrote:
> On 2015/05/26 10:23:53, pbos wrote:
> > PTAL!
> > 
> > This might trigger
https://code.google.com/p/chromium/issues/detail?id=491112,
> > if not we can narrow down the search.
> > 
> > Either way this is something we want to do regardless of above bug. :)
> 
> Less convinced it'll trigger the above bug, I added some printfs and the base
> channel wasn't sending padding. If it's the base-channel encoder acting up for
> above bug, this might help resolve it (since there's no base channel after
this
> change).

Sorry, that should've read "base encoder".
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted