Issue 55639004: Added fields for configuration information to the protobuf format

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 55639004: Added fields for configuration information to the protobuf format

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 5 months ago by terelius

Modified:
6 years, 5 months ago

Reviewers:

CC:
webrtc-reviews_webrtc.org, tterriberry, HL, kwiberg, Tina

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Added fields for configuration information to the protobuf format in the ACMDump. The ACMDump interface itself is not updated, so there is no way (yet) to actually write the configuration fields. BUG=

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -1 line)			Patch
	M	webrtc/modules/audio_coding/main/acm2/dump.proto	View		5 chunks	+81 lines, -1 line	0 comments	Download

Trybot results: Sign in to try more bots

Project "webrtc" does not have a commit queue.