Issue 56589004: AppRtcDemo patch as per https://webrtc-codereview.appspot.com/53669004/

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 2 months ago by cpaulin

Modified:
4 years, 2 months ago

Reviewers:

CC:
webrtc-reviews_webrtc.org

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/heads/master

Project:
webrtc

Visibility:
Public.

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -3 lines)			Patch
M	talk/examples/android/res/values/strings.xml	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	talk/examples/android/res/xml/preferences.xml	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	talk/examples/android/src/org/appspot/apprtc/CallActivity.java	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	talk/examples/android/src/org/appspot/apprtc/ConnectActivity.java	View		4 chunks	+9 lines, -0 lines	0 comments	Download
M	talk/examples/android/src/org/appspot/apprtc/PeerConnectionClient.java	View		5 chunks	+19 lines, -2 lines	0 comments	Download
M	talk/examples/android/src/org/appspot/apprtc/SettingsActivity.java	View		4 chunks	+4 lines, -0 lines	0 comments	Download
M	talk/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Trybot results: android_s5 android_s4 android_s3 android_rel android_gn_rel android_gn android_clang android_arm64_rel android Sign in to try more bots

Project "webrtc" does not have a commit queue.