Issue 56659004: Re-enable LLVM LTO on Neon targets.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 56659004: Re-enable LLVM LTO on Neon targets.

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 3 months ago by pcc

Modified:
6 years, 3 months ago

Reviewers:
fbarchard

Base URL:
https://chromium.googlesource.com/libyuv/libyuv.git@master

Target Ref:
refs/heads/master

Project:
libyuv

Visibility:
Public.

More Reviews

Description

Re-enable LLVM LTO on Neon targets. LTO was disabled due to a GCC compiler bug that does not affect LLVM. This fixes the build in the cfi_vptr==1 configuration, which requires LLVM LTO. R=fbarchard@google.com BUG=chromium:469376

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	libyuv.gyp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Trybot results: Sign in to try more bots

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pcc

6 years, 3 months ago (2015-08-18 21:43:46 UTC) #3

On 2015/08/18 21:39:17, fbarchard wrote:
> lgtm

Thanks. May I ask you to land this for me? I do not have permission to commit to
libyuv.

$ git cl land
Using 50% similarity for rename/copy detection. Override with --similarity.
Running presubmit commit checks ...

Presubmit checks passed.
Description:
Re-enable LLVM LTO on Neon targets.

LTO was disabled due to a GCC compiler bug that does not affect LLVM.
This fixes the build in the cfi_vptr==1 configuration, which requires LLVM LTO.

R=fbarchard@google.com
BUG=chromium:469376

Review URL: https://webrtc-codereview.appspot.com/56659004 .
 libyuv.gyp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Counting objects: 3, done.
Delta compression using up to 40 threads.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 512 bytes | 0 bytes/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: refs: 1, done    
error: failed to push some refs to
'https://chromium.googlesource.com/a/libyuv/libyuv.git'
Failed to push. If this persists, please file a bug.

Expand Messages | Collapse Messages