WebRTC Code Reviews
Help | Chromium Project | Sign in
(10888)

Issue 56679004: Fix potential crashes in the screen capturer on Mac (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by Sergey Ulanov
Modified:
3 years, 8 months ago
Reviewers:
jiayang
CC:
webrtc-reviews_webrtc.org, tterriberry
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix potential crashes in the screen capturer on Mac ScreenCapturerMac wasn't handling the following two cases properly which could cause crashes: 1. CGDisplayCreateImage() returns image with depth other than 32-bit 2. CGDisplayCreateImage() returns image with dimensions different from expected (e.g. when screen resolution is being changed). I suspect that (2) was causing the linked bug. BUG=504927

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -43 lines) Patch
M webrtc/modules/desktop_capture/screen_capturer_mac.mm View 5 chunks +50 lines, -43 lines 0 comments Download
Trybot results:
Project "webrtc" does not have a commit queue.

Messages

Total messages: 6 (3 generated)
Sergey Ulanov
4 years ago (2015-10-26 18:30:01 UTC) #4
Sergey Ulanov
ping!
3 years, 8 months ago (2016-03-18 22:33:39 UTC) #5
Sergey Ulanov
3 years, 8 months ago (2016-03-18 23:04:13 UTC) #6
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted