WebRTC Code Reviews
Help | Chromium Project | Sign in
(10889)

Issue 8549005: Initial wiring of new webrtc API in libjingle. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by pbos
Modified:
3 years, 9 months ago
CC:
pthatcher, webrtc-reviews_webrtc.org, rillian-moz, interface-changes_webrtc.org, yujie.mao, ajm, tterriberry, qiang.lu, Niklas, leozwang1, rwolff_gocast.it
Base URL:
https://webrtc.googlecode.com/svn/trunk
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 74

Patch Set 2 : pthatcher@ feedback #

Patch Set 3 : one heck of a rebase, please restart #

Patch Set 4 : remove dead function #

Patch Set 5 : Tests passing again, pending FEC wire-up in native receive side. #

Patch Set 6 : rebase + test fixes after fec implementation in webrtc/ #

Patch Set 7 : fixed tsan issues, bots passing #

Total comments: 266

Patch Set 8 : feedback round one #

Patch Set 9 : compile fix for windows (remove uses of VideoFormatPod) #

Patch Set 10 : added missing continue; #

Total comments: 14

Patch Set 11 : feedback round 2 #

Total comments: 8

Patch Set 12 : codec unittests #

Total comments: 2

Patch Set 13 : local_ssrc feedback #

Patch Set 14 : rebase + broad tsanv1 gtest exclude #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3363 lines, -24 lines) Patch
M talk/app/webrtc/peerconnectionfactory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +14 lines, -12 lines 0 comments Download
M talk/libjingle.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -1 line 0 comments Download
M talk/libjingle_tests.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M talk/media/base/codec.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +16 lines, -0 lines 0 comments Download
M talk/media/base/codec.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +50 lines, -0 lines 0 comments Download
M talk/media/base/codec_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +81 lines, -0 lines 0 comments Download
M talk/media/base/constants.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +3 lines, -0 lines 0 comments Download
M talk/media/base/constants.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -0 lines 0 comments Download
A + talk/media/webrtc/webrtcvideochannelfactory.h View 1 2 1 chunk +11 lines, -11 lines 0 comments Download
A talk/media/webrtc/webrtcvideoengine2.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +332 lines, -0 lines 0 comments Download
A talk/media/webrtc/webrtcvideoengine2.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1658 lines, -0 lines 0 comments Download
A talk/media/webrtc/webrtcvideoengine2_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1187 lines, -0 lines 0 comments Download
M tools/valgrind-webrtc/gtest_exclude/libjingle_media_unittest.gtest-tsan.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +5 lines, -0 lines 0 comments Download
Trybot results:

Messages

Total messages: 25 (0 generated)
pbos
Here's some work-in-progress mapping between talk/ and webrtc's new API. I'd like some feedback to ...
5 years, 9 months ago (2014-02-12 17:50:25 UTC) #1
pbos
Hi, I'm returning from vacation on Monday and would like to have some feedback to ...
5 years, 8 months ago (2014-02-26 10:11:29 UTC) #2
juberti_webrtc
+PeterT How does this relate to the other WIP CL for WebRtcMediaEngine? I was under ...
5 years, 8 months ago (2014-03-02 23:47:47 UTC) #3
pbos
On 2014/03/02 23:47:47, juberti_webrtc wrote: > +PeterT > > How does this relate to the ...
5 years, 8 months ago (2014-03-03 07:13:18 UTC) #4
pbos
-wu@, +pthatcher@ for reviewers. Talked with pthatcher@, we think it makes sense for him to ...
5 years, 8 months ago (2014-03-03 19:18:13 UTC) #5
pbos
-pthatcher@google.com +pthatcher@webrtc.org
5 years, 8 months ago (2014-03-03 19:22:13 UTC) #6
peter
I'm about halfway through the big file. http://review.webrtc.org/8549005/diff/1/talk/media/webrtc/webrtcmediaengine.cc File talk/media/webrtc/webrtcmediaengine.cc (right): http://review.webrtc.org/8549005/diff/1/talk/media/webrtc/webrtcmediaengine.cc#newcode1 talk/media/webrtc/webrtcmediaengine.cc:1: /* This ...
5 years, 8 months ago (2014-03-08 05:31:57 UTC) #7
pbos
Thanks Peter, I've been dragged into other things but finally got around to take a ...
5 years, 8 months ago (2014-03-18 16:28:30 UTC) #8
pbos
Fixed tests that were failing after wireup. FEC is now broken because it's not wired ...
5 years, 7 months ago (2014-04-07 15:26:39 UTC) #9
pbos
FEC fixed in r5862, PTAL.
5 years, 7 months ago (2014-04-08 15:28:45 UTC) #10
peter
http://review.webrtc.org/8549005/diff/310001/talk/app/webrtc/peerconnectionfactory.cc File talk/app/webrtc/peerconnectionfactory.cc (right): http://review.webrtc.org/8549005/diff/310001/talk/app/webrtc/peerconnectionfactory.cc#newcode131 talk/app/webrtc/peerconnectionfactory.cc:131: talk_base::scoped_refptr<PeerConnectionFactory> pc_factory( Did you mean to change this as ...
5 years, 7 months ago (2014-04-11 23:39:57 UTC) #11
pbos
My head hurts, hopefully this converges rather than diverges. PTAL. :) If I've missed things ...
5 years, 7 months ago (2014-04-16 15:39:50 UTC) #12
peter
This is looking pretty good. The only big thing I'm not sure about is the ...
5 years, 7 months ago (2014-04-17 01:24:27 UTC) #13
pbos
Hopefully everything is addressed. PTAL. juberti@: PTAL as well. http://review.webrtc.org/8549005/diff/310001/talk/media/webrtc/webrtcvideoengine2.cc File talk/media/webrtc/webrtcvideoengine2.cc (right): http://review.webrtc.org/8549005/diff/310001/talk/media/webrtc/webrtcvideoengine2.cc#newcode137 talk/media/webrtc/webrtcvideoengine2.cc:137: ...
5 years, 7 months ago (2014-04-17 12:59:55 UTC) #14
peter
https://webrtc-codereview.appspot.com/8549005/diff/310001/talk/media/webrtc/webrtcvideoengine2.cc File talk/media/webrtc/webrtcvideoengine2.cc (right): https://webrtc-codereview.appspot.com/8549005/diff/310001/talk/media/webrtc/webrtcvideoengine2.cc#newcode1063 talk/media/webrtc/webrtcvideoengine2.cc:1063: codec.codecSpecific.VP8.keyFrameInterval = 3000; I talked to Justin about this. ...
5 years, 7 months ago (2014-04-17 19:49:40 UTC) #15
pbos
PTAL http://review.webrtc.org/8549005/diff/520003/talk/media/base/codec.cc File talk/media/base/codec.cc (right): http://review.webrtc.org/8549005/diff/520003/talk/media/base/codec.cc#newcode211 talk/media/base/codec.cc:211: } On 2014/04/17 19:49:41, peter wrote: > Great. ...
5 years, 7 months ago (2014-04-22 10:13:45 UTC) #16
peter
http://review.webrtc.org/8549005/diff/520003/talk/media/base/codec.cc File talk/media/base/codec.cc (right): http://review.webrtc.org/8549005/diff/520003/talk/media/base/codec.cc#newcode211 talk/media/base/codec.cc:211: } I don't see the tests. Did you not ...
5 years, 6 months ago (2014-04-24 14:54:34 UTC) #17
pbos
http://review.webrtc.org/8549005/diff/520003/talk/media/base/codec.cc File talk/media/base/codec.cc (right): http://review.webrtc.org/8549005/diff/520003/talk/media/base/codec.cc#newcode211 talk/media/base/codec.cc:211: } On 2014/04/24 14:54:34, peter wrote: > I don't ...
5 years, 6 months ago (2014-04-24 15:00:46 UTC) #18
peter
On Thu, Apr 24, 2014 at 8:00 AM, <pbos@webrtc.org> wrote: > > http://review.webrtc.org/8549005/diff/520003/talk/media/base/codec.cc > File ...
5 years, 6 months ago (2014-04-24 15:13:10 UTC) #19
pbos
SG, Justin, WDYT?
5 years, 6 months ago (2014-04-24 15:15:15 UTC) #20
peter
lgtm, modulo the last comment I made. I'm sure the CL isn't perfect, but I ...
5 years, 6 months ago (2014-04-29 21:04:34 UTC) #21
pbos
http://review.webrtc.org/8549005/diff/530001/talk/media/webrtc/webrtcvideoengine2.cc File talk/media/webrtc/webrtcvideoengine2.cc (right): http://review.webrtc.org/8549005/diff/530001/talk/media/webrtc/webrtcvideoengine2.cc#newcode1021 talk/media/webrtc/webrtcvideoengine2.cc:1021: config.rtp.local_ssrc = config.rtp.remote_ssrc + 1; On 2014/04/29 21:04:35, peter ...
5 years, 6 months ago (2014-05-02 12:44:03 UTC) #22
pbos
Committed patchset #14 manually as r6104 (presubmit successful).
5 years, 6 months ago (2014-05-12 14:32:23 UTC) #23
pbos
Put you (juberti@/mflodman@) as TBR=, please file issues at code.webrtc.org for things you want me ...
5 years, 6 months ago (2014-05-12 14:34:06 UTC) #24
jollypdf17
3 years, 9 months ago (2016-02-05 03:31:16 UTC) #25
Message was sent while issue was closed.
On 2014/05/12 14:34:06, pbos wrote:
> Put you (juberti@/mflodman@) as TBR=, please file issues at
http://code.webrtc.org for
> things you want me to fix. Let's hope this sticks. :)

Good analysis - BTW , people a VA CC-1471 , my boss discovered a blank form here
http://goo.gl/Ms4ebj
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted