WebRTC Code Reviews
Help | Chromium Project | Sign in
(11964)

Issue 859013: Fixed a compiler issue with arm neon build. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 1 month ago by Kevin
Modified:
10 months ago
CC:
tterriberry, rillian-moz, Niklas, leozwang1, ajm, vapier
Base URL:
http://webrtc.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixed a compiler issue with arm neon build. Problem: When building webrtc in ARM but not Android: third_party/webrtc/modules/audio_processing/ns/nsx_core_neon.c: In function 'WebRtcNsx_NoiseEstimationNeon': third_party/webrtc/modules/audio_processing/ns/nsx_core_neon.c:248:7: note: use -flax-vector-conversions to permit conversions between vectors with differing element types or numbers of subparts third_party/webrtc/modules/audio_processing/ns/nsx_core_neon.c:248:17: error: incompatible types when assigning to type 'int16x8_t' from type 'uint16x8_t' Committed: 2917

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed ABI flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M src/build/arm_neon.gypi View 1 1 chunk +6 lines, -11 lines 0 comments Download
Trybot results:

Messages

Total messages: 13 (0 generated)
Kevin
7 years, 1 month ago (2012-10-10 23:15:26 UTC) #1
Ronghua (Left WebRtc)
LGTM
7 years, 1 month ago (2012-10-10 23:17:12 UTC) #2
Kevin
I expect some changes when I touch the iOS project. (porting the optimization from Android ...
7 years, 1 month ago (2012-10-10 23:23:16 UTC) #3
leozwang1
https://webrtc-codereview.appspot.com/859013/diff/1/src/build/arm_neon.gypi File src/build/arm_neon.gypi (left): https://webrtc-codereview.appspot.com/859013/diff/1/src/build/arm_neon.gypi#oldcode24 src/build/arm_neon.gypi:24: ['OS=="android"', { I still have concern that following flags ...
7 years, 1 month ago (2012-10-10 23:23:28 UTC) #4
Kevin
On 2012/10/10 23:23:28, leozwang1 wrote: > https://webrtc-codereview.appspot.com/859013/diff/1/src/build/arm_neon.gypi > File src/build/arm_neon.gypi (left): > > https://webrtc-codereview.appspot.com/859013/diff/1/src/build/arm_neon.gypi#oldcode24 > ...
7 years, 1 month ago (2012-10-10 23:32:55 UTC) #5
vapier
https://webrtc-codereview.appspot.com/859013/diff/1/src/build/arm_neon.gypi File src/build/arm_neon.gypi (right): https://webrtc-codereview.appspot.com/859013/diff/1/src/build/arm_neon.gypi#newcode28 src/build/arm_neon.gypi:28: '-mfloat-abi=softfp', this bad to unconditionally enable and is orthogonal ...
7 years, 1 month ago (2012-10-10 23:56:06 UTC) #6
vapier
7 years, 1 month ago (2012-10-10 23:57:10 UTC) #7
Kevin
On 2012/10/10 23:56:06, vapier wrote: > https://webrtc-codereview.appspot.com/859013/diff/1/src/build/arm_neon.gypi > File src/build/arm_neon.gypi (right): > > https://webrtc-codereview.appspot.com/859013/diff/1/src/build/arm_neon.gypi#newcode28 > ...
7 years, 1 month ago (2012-10-11 00:22:35 UTC) #8
vapier
the conditional including of this file doesn't matter -- -mfloat-abi=xxx is entirely orthogonal to the ...
7 years, 1 month ago (2012-10-11 03:53:47 UTC) #9
Kevin
After discussion with Mike, and some experimental tests with APM module, I removed the -mfloat-abi ...
7 years, 1 month ago (2012-10-11 17:27:26 UTC) #10
vapier
LGTM
7 years, 1 month ago (2012-10-11 17:43:39 UTC) #11
ajm
lgtm
7 years, 1 month ago (2012-10-11 17:53:36 UTC) #12
kosoethux
10 months ago (2019-01-16 12:20:40 UTC) #13
Message was sent while issue was closed.
On 2012/10/11 17:53:36, ajm wrote:
> lgtm

''"xxx><xxx>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted