WebRTC Code Reviews
Help | Chromium Project | Sign in
(163)

Issue 9869004: Replace labs with std::abs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by pbos
Modified:
5 years, 11 months ago
Reviewers:
thakis, earthdok, ajm
CC:
webrtc-reviews_webrtc.org, rillian-moz, tterriberry, leozwang1, mikhals, Stefan
Base URL:
https://webrtc.googlecode.com/svn/trunk
Visibility:
Public.

Description

Replace labs with std::abs. Resolves clang 3.5 warnings on OS X for -Wabsolute-value. BUG=chromium:351479 R=andrew@webrtc.org, thakis@chromium.org Committed: https://code.google.com/p/webrtc/source/detail?r=5692

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webrtc/modules/video_coding/main/source/receiver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/call_perf_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
Trybot results:

Messages

Total messages: 6 (0 generated)
pbos
Hi, can you check and see if this patch resolves the compile issues you're seeing ...
5 years, 11 months ago (2014-03-12 14:11:38 UTC) #1
thakis
lgtm, thanks. This worked for me locally. You can say "BUG=chromium:351479" is you want.
5 years, 11 months ago (2014-03-12 16:15:06 UTC) #2
pbos
Done, thanks. Andrew can you quick LGTM this?
5 years, 11 months ago (2014-03-12 16:51:25 UTC) #3
ajm
lgtm
5 years, 11 months ago (2014-03-12 21:55:51 UTC) #4
earthdok
This broke libc++ build of Chromium: http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Linux%20MSan/builds/1373/steps/compile/logs/stdio ../../third_party/webrtc/modules/video_coding/main/source/receiver.cc:159:14: error: no member named 'abs' in namespace ...
5 years, 11 months ago (2014-03-18 10:39:07 UTC) #5
pbos
5 years, 11 months ago (2014-03-18 13:27:29 UTC) #6
Fixed in https://code.google.com/p/webrtc/source/detail?r=5715.


On Tue, Mar 18, 2014 at 11:39 AM, <earthdok@chromium.org> wrote:

> This broke libc++ build of Chromium:
>
> http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Linux%20MSan/
> builds/1373/steps/compile/logs/stdio
>
> ../../third_party/webrtc/modules/video_coding/main/
> source/receiver.cc:159:14:
> error: no member named 'abs' in namespace 'std'; did you mean simply
> 'abs'?
>
> Needs "#include <cstdlib>"
>
> https://webrtc-codereview.appspot.com/9869004/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted