Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Recent Closed Issues

1 - 20 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
50099004	Fold AudioEncoderMutable into AudioEncoder (Closed)	kwiberg	HL, minyue, Jelena, mkaslann12	25	1 day, 21 hours
437002	Refactoring audio_device_test_api for gtest and execution on all platforms. (Closed)	kjellander	no longer working on webrtc, henrika_webrtc	28	3 months, 1 week
659004	An OS-independent sleep function, and one usage thereof. (Closed)	hta-webrtc	co.1620.co, hellner_GONE_FROM_WEBRTC		1 year, 4 months
56679004	Fix potential crashes in the screen capturer on Mac (Closed)	Sergey Ulanov	jiayang		1 year, 5 months
47269004	Remove set_flags() from PortAllocatorSession. Remove RawTransport. (Closed)	Sergey Ulanov	pthatcher		1 year, 5 months
28849004	replace inline assembly WebRtcNsx_AnalysisUpdate by intrinsics. (Closed)	zhongwei.yao	ajm	6	1 year, 5 months
36439004	Revert r7886:7887. (Closed)	pbos	tommi, kjellander, pthatcher	1	1 year, 6 months
8549005	Initial wiring of new webrtc API in libjingle. (Closed)	pbos	juberti_webrtc, mflodman, pthatcher, peter	364	1 year, 6 months
39969004	Remove SSRCDatabase from RTPSender. (Closed)	pbos	Stefan, mflodman		1 year, 6 months
54549004	Move decoder attributes to webrtc::VideoDecoder. (Closed)	pbos	Stefan, mflodman	25	1 year, 6 months
38829005	Remove POSIX channel_transport ConditionVariables. (Closed)	pbos	tommi	2	1 year, 7 months
50049004	Remove VideoCodec::extra_options void pointer. (Closed)	pbos	andresp-webrtc, mflodman, Stefan	1	1 year, 7 months
51349004	Create master.tryserver.libyuv bucket (Closed)	nodir	kjellander	2	1 year, 7 months
35569004	Delete webrtc/libjingle, except for xmpp/ and xmllite/, which must stay around until all the parts … (Closed)	pthatcher	juberti_webrtc, pbos		1 year, 8 months
51129004	Remove webrtc::Config from ChannelGroup. (Closed)	pbos	mflodman		1 year, 8 months
55489004	Remove base channels + receiver ViEEncoder. (Closed)	pbos	mflodman		1 year, 8 months
57689004	Update libsrtp to 1.5.2 in DEPS (Closed)	tpsiaki	juberti_webrtc, noahric (chromium), jiayang		1 year, 8 months
2145004	Added a test that verifies that waiting for a condition variable (Closed)	hta-webrtc	tommi	4	1 year, 8 months
59409005	Use WebRTC API to convert byteorder in srtpfilter. (Closed)	tpsiaki	juberti_webrtc, noahric (chromium), noahric, jiayang		1 year, 8 months
59399004	Add a sanitizer.gni import to the GN build. (Closed)	brettw	fbarchard1, fbarchard		1 year, 11 months

1 - 20 Older ›